From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58951)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc14X-00035E-Ii
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:13:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc14V-0005Vz-Ne
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:13:49 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:35483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc14V-0005Vk-Du
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:13:47 -0400
Received: by pbbro12 with SMTP id ro12so8662542pbb.4
	for <qemu-devel@nongnu.org>; Tue, 05 Jun 2012 14:13:45 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FCE7684.2070206@redhat.com>
Date: Tue, 05 Jun 2012 23:13:40 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1337683555-13301-1-git-send-email-lersek@redhat.com>
In-Reply-To: <1337683555-13301-1-git-send-email-lersek@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor,
	rebase -net/-netdev parsing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>
Cc: qemu-devel@nongnu.org

Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
> Inspired by [1], the first half of this series attempts to implement a new
> visitor that should clean up defining and processing command line options.
> For a more detailed description, please see "[PATCH 04/16] qapi: introduce
> OptsVisitor".
> 
> The second half converts -net/-netdev parsing to the new visitor.
> 
> The series depends on "qapi: convert netdev_add & netdev_del" v5, see [2].
> 
> Comments highly appreciated; please keep me CC'd. Thank you.
> 
> [1] http://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg02512.html
> [2] http://lists.nongnu.org/archive/html/qemu-devel/2012-05/msg02841.html
> 
> Laszlo Ersek (15):
>   qapi: introduce "size" type
>   expose QemuOpt and QemuOpts struct definitions to interested parties
>   qapi: introduce OptsVisitor
>   qapi schema: remove trailing whitespace
>   qapi schema: add Netdev types
>   hw, net: "net_client_type" -> "NetClientOptionsKind" (qapi-generated)
>   convert net_client_init() to OptsVisitor
>   convert net_init_nic() to NetClientOptions
>   convert net_init_dump() to NetClientOptions
>   convert net_init_slirp() to NetClientOptions
>   convert net_init_socket() to NetClientOptions
>   convert net_init_vde() to NetClientOptions
>   convert net_init_tap() to NetClientOptions
>   convert net_init_bridge() to NetClientOptions
>   remove unused QemuOpts parameter from net init functions
> 
> Paolo Bonzini (1):
>   qapi: fix error propagation

There is one small mistake that needs to be addressed in a v2, so it
would be great if you could use the int*_t visitors to avoid
complicating the code with range checks.

Otherwise very nice, sorry for the time it took me to do the review.

Paolo