From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47478)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc1I7-0005RN-UI
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:27:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc1I6-0000oI-Am
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:27:51 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:56693)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc1I6-0000o2-1x
	for qemu-devel@nongnu.org; Tue, 05 Jun 2012 17:27:50 -0400
Received: by dadv2 with SMTP id v2so8487585dad.4
	for <qemu-devel@nongnu.org>; Tue, 05 Jun 2012 14:27:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FCE79CE.3030905@redhat.com>
Date: Tue, 05 Jun 2012 23:27:42 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1337683555-13301-1-git-send-email-lersek@redhat.com>
	<1337683555-13301-13-git-send-email-lersek@redhat.com>
	<4FCE73C8.6030906@redhat.com> <4FCE76D2.9070403@redhat.com>
In-Reply-To: <4FCE76D2.9070403@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 12/16] convert net_init_socket() to
	NetClientOptions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: Laszlo Ersek <lersek@redhat.com>, qemu-devel@nongnu.org

Il 05/06/2012 23:14, Eric Blake ha scritto:
> On 06/05/2012 03:02 PM, Paolo Bonzini wrote:
>> Il 22/05/2012 12:45, Laszlo Ersek ha scritto:
>>> +    if (sock->has_fd + sock->has_listen + sock->has_connect + sock->has_mcast +
>>> +        sock->has_udp != 1) {
>>
>> Please add a cast, this doesn't work with C99 bool.
> 
> Huh?  Where does C99 state that?

Doh, I confused ++ and +.

Thanks for restoring some of my faith in X3J11.

Paolo