From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc3Oy-0003gw-O9 for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:46:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc3L0-0007Pm-GG for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:43:04 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:55464) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc3L0-0007Ob-C3 for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:38:58 -0400 Received: from /spool/local by e8.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jun 2012 19:38:54 -0400 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 02F9C38C8026 for ; Tue, 5 Jun 2012 19:38:53 -0400 (EDT) Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q55NcqGj154680 for ; Tue, 5 Jun 2012 19:38:52 -0400 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q55NcqY6009876 for ; Tue, 5 Jun 2012 20:38:52 -0300 Message-ID: <4FCE9887.5010902@us.ibm.com> Date: Wed, 06 Jun 2012 07:38:47 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com> <1338858018-17189-17-git-send-email-mdroth@linux.vnet.ibm.com> <4FCDDEC6.5070005@redhat.com> In-Reply-To: <4FCDDEC6.5070005@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 16/17] qidl: add qidl-generated vmstate fields for rtc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: owasserm@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, Michael Roth , yamahata@valinux.co.jp, pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de On 06/05/2012 06:26 PM, Avi Kivity wrote: > On 06/05/2012 04:00 AM, Michael Roth wrote: >> Initial check-in of the qidl-generated vmstate fields for rtc. >> > > Don't, please. As Mike said in another note, we want to keep the device schema in the tree so we can determine when it changes in 'make check' and complain loudly. But I think we need a better way to do this. Something like a 'make schema-update' target that will regenerate schemas and prepare them for checkin. Regards, Anthony Liguori