From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc3Qd-0003m8-5j for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:48:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc3N6-0007zb-Tm for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:44:46 -0400 Received: from e9.ny.us.ibm.com ([32.97.182.139]:41119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc3N6-0007vR-PE for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:41:08 -0400 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jun 2012 19:41:04 -0400 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 817A338C8059 for ; Tue, 5 Jun 2012 19:41:00 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q55Nf00a154338 for ; Tue, 5 Jun 2012 19:41:00 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q565BqOl029829 for ; Wed, 6 Jun 2012 01:11:52 -0400 Message-ID: <4FCE9904.6090908@us.ibm.com> Date: Wed, 06 Jun 2012 07:40:52 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com> <1338858018-17189-2-git-send-email-mdroth@linux.vnet.ibm.com> <4FCDD06D.2050003@redhat.com> <20120605162141.GK2916@illuin> <4FCE6458.2060003@redhat.com> In-Reply-To: <4FCE6458.2060003@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , yamahata@valinux.co.jp, quintela@redhat.com, qemu-devel@nongnu.org, Michael Roth , owasserm@redhat.com, akong@redhat.com, afaerber@suse.de On 06/06/2012 03:56 AM, Paolo Bonzini wrote: > Il 05/06/2012 18:21, Michael Roth ha scritto: >> The only way I can think of getting around this is to do nasty things >> like adding an >> >> #include "qapi-generated/mc146818rtc-qapi-visit.c"; >> >> in hw/mc146818rtc.c. > > It doesn't look that ugly, though perhaps I'm biased because that's > again exactly what GCC does. A cleaner way to do this this to have mc146818rtc-qapi-visit.c have: #include "mc146818rtc.c" As the first line of the file. Then don't build mc146818rtc.c directly and instead only build the qapi-visit.o variant. This could all be done through make magic too. Regards, Anthony Liguori > > Paolo > >