From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc3RV-0003tO-Iu for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc3Nt-00089b-BJ for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:45:41 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:53875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc3Nt-000896-79 for qemu-devel@nongnu.org; Tue, 05 Jun 2012 19:41:57 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jun 2012 19:41:53 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 9399C38C803A for ; Tue, 5 Jun 2012 19:41:36 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q55NfaqT150142 for ; Tue, 5 Jun 2012 19:41:36 -0400 Received: from d01av01.pok.ibm.com (loopback [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q565CShS031997 for ; Wed, 6 Jun 2012 01:12:28 -0400 Message-ID: <4FCE992A.2030200@us.ibm.com> Date: Wed, 06 Jun 2012 07:41:30 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com> <1338858018-17189-2-git-send-email-mdroth@linux.vnet.ibm.com> <4FCDDA12.4040907@redhat.com> <4FCDF944.5000507@redhat.com> In-Reply-To: <4FCDF944.5000507@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: yamahata@valinux.co.jp, quintela@redhat.com, qemu-devel@nongnu.org, Michael Roth , owasserm@redhat.com, Avi Kivity , pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de On 06/05/2012 08:19 PM, Gerd Hoffmann wrote: > Hi, > >> >> >> Suggestion: add a _guest marker for ordinary state. Fail the build on >> unmarked fields. This ensures that some thought is given to each field, >> instead of having a default that may be correct most of the time, but >> not always. >> >> Suggestion: add a mandatory position hint (_guest(7) or _pos(7)) that >> generates ordering within the fields. This decouples the order of lines >> in the struct from the protocol, so you can add state where it make >> sense, or rearrange lines when they don't, and detect copy/paste errors. > > I wouldn't make the position mandatory. I expect the next generation > migration wire protocol transmits the field names anyway, so the > ordering will not matter any more, we need it for compatibility with > today's format only. +1 Regards, Anthony Liguori > > cheers, > Gerd > > >