qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Jens Freimann <jfrei@linux.vnet.ibm.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix build of kvm-all.c when no KVM_CAP_IRQ_ROUTING
Date: Wed, 06 Jun 2012 01:48:35 +0200	[thread overview]
Message-ID: <4FCE9AD3.1080306@suse.de> (raw)
In-Reply-To: <1338880564-12277-1-git-send-email-jfrei@linux.vnet.ibm.com>

Am 05.06.2012 09:16, schrieb Jens Freimann:
> In kvm-all.c an #ifdef KVM_CAP_IRQ_ROUTING was missing in two
> places which broke the build when this capability is not enabled.
> Found when building the s390-softmmu target.
> 
> Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>

A patch by Jan moves the first chunk instead and fixes another issue as
well in v2. Cc'ing Jan to verify.

Andreas

> ---
>  kvm-all.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kvm-all.c b/kvm-all.c
> index 489ee53..95634ef 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -62,10 +62,12 @@ typedef struct KVMSlot
>  
>  typedef struct kvm_dirty_log KVMDirtyLog;
>  
> +#ifdef KVM_CAP_IRQ_ROUTING
>  typedef struct KVMMSIRoute {
>      struct kvm_irq_routing_entry kroute;
>      QTAILQ_ENTRY(KVMMSIRoute) entry;
>  } KVMMSIRoute;
> +#endif
>  
>  struct KVMState
>  {
> @@ -1286,7 +1288,9 @@ int kvm_init(void)
>      s->pit_state2 = kvm_check_extension(s, KVM_CAP_PIT_STATE2);
>  #endif
>  
> +#ifdef KVM_CAP_IRQ_ROUTING
>      s->direct_msi = (kvm_check_extension(s, KVM_CAP_SIGNAL_MSI) > 0);
> +#endif
>  
>      ret = kvm_arch_init(s);
>      if (ret < 0) {

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

      reply	other threads:[~2012-06-05 23:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-05  7:16 [Qemu-devel] [PATCH] Fix build of kvm-all.c when no KVM_CAP_IRQ_ROUTING Jens Freimann
2012-06-05 23:48 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCE9AD3.1080306@suse.de \
    --to=afaerber@suse.de \
    --cc=jan.kiszka@siemens.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).