From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51150)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc8Xa-00076l-IR
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:12:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc8XY-0008Qi-TL
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:12:18 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:58693)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Sc8XY-0008Gz-L1
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:12:16 -0400
Received: by mail-pb0-f45.google.com with SMTP id ro12so9146279pbb.4
	for <qemu-devel@nongnu.org>; Tue, 05 Jun 2012 22:12:15 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FCEE6A8.4090906@redhat.com>
Date: Wed, 06 Jun 2012 07:12:08 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1338858018-17189-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4FCDD06D.2050003@redhat.com> <20120605162141.GK2916@illuin>
	<4FCE6458.2060003@redhat.com> <4FCE9904.6090908@us.ibm.com>
In-Reply-To: <4FCE9904.6090908@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>, owasserm@redhat.com, quintela@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, yamahata@valinux.co.jp, akong@redhat.com, afaerber@suse.de

Il 06/06/2012 01:40, Anthony Liguori ha scritto:
>>
>>> The only way I can think of getting around this is to do nasty things
>>> like adding an
>>>
>>> #include "qapi-generated/mc146818rtc-qapi-visit.c";
>>>
>>> in hw/mc146818rtc.c.
>>
>> It doesn't look that ugly, though perhaps I'm biased because that's
>> again exactly what GCC does.
> 
> A cleaner way to do this this to have mc146818rtc-qapi-visit.c have:
> 
> #include "mc146818rtc.c"
> 
> As the first line of the file.  Then don't build mc146818rtc.c directly
> and instead only build the qapi-visit.o variant.
> 
> This could all be done through make magic too.

Sounds like we have very different definitions of clean. :)

Paolo