From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc91l-0007pX-75 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:43:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sc91j-0006u6-J3 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:43:28 -0400 Received: from e37.co.us.ibm.com ([32.97.110.158]:49642) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sc91j-0006tu-CC for qemu-devel@nongnu.org; Wed, 06 Jun 2012 01:43:27 -0400 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 5 Jun 2012 23:43:23 -0600 Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com [9.17.195.228]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 0BDD63E40049 for ; Wed, 6 Jun 2012 05:43:20 +0000 (WET) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q565hKjD187238 for ; Tue, 5 Jun 2012 23:43:20 -0600 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q565iAxO009276 for ; Tue, 5 Jun 2012 23:44:10 -0600 Message-ID: <4FCEEDF3.7010804@us.ibm.com> Date: Wed, 06 Jun 2012 13:43:15 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com> <1338858018-17189-2-git-send-email-mdroth@linux.vnet.ibm.com> <4FCDD06D.2050003@redhat.com> <20120605162141.GK2916@illuin> <4FCE6458.2060003@redhat.com> <4FCE9904.6090908@us.ibm.com> <4FCEE6A8.4090906@redhat.com> In-Reply-To: <4FCEE6A8.4090906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , owasserm@redhat.com, quintela@redhat.com, Michael Roth , qemu-devel@nongnu.org, yamahata@valinux.co.jp, akong@redhat.com, afaerber@suse.de On 06/06/2012 01:12 PM, Paolo Bonzini wrote: > Il 06/06/2012 01:40, Anthony Liguori ha scritto: >>> >>>> The only way I can think of getting around this is to do nasty things >>>> like adding an >>>> >>>> #include "qapi-generated/mc146818rtc-qapi-visit.c"; >>>> >>>> in hw/mc146818rtc.c. >>> >>> It doesn't look that ugly, though perhaps I'm biased because that's >>> again exactly what GCC does. >> >> A cleaner way to do this this to have mc146818rtc-qapi-visit.c have: >> >> #include "mc146818rtc.c" >> >> As the first line of the file. Then don't build mc146818rtc.c directly >> and instead only build the qapi-visit.o variant. >> >> This could all be done through make magic too. > > Sounds like we have very different definitions of clean. :) Fair enough :-) Either approach is fine by me FWIW. Regards, Anthony Liguori > > Paolo >