From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScAxy-0001po-EQ for qemu-devel@nongnu.org; Wed, 06 Jun 2012 03:47:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScAxt-0001QM-Mi for qemu-devel@nongnu.org; Wed, 06 Jun 2012 03:47:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScAxt-0001Q2-Eb for qemu-devel@nongnu.org; Wed, 06 Jun 2012 03:47:37 -0400 Message-ID: <4FCF0B13.4020000@redhat.com> Date: Wed, 06 Jun 2012 10:47:31 +0300 From: Avi Kivity MIME-Version: 1.0 References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com> <1338858018-17189-17-git-send-email-mdroth@linux.vnet.ibm.com> <4FCDDEC6.5070005@redhat.com> <4FCE9887.5010902@us.ibm.com> In-Reply-To: <4FCE9887.5010902@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 16/17] qidl: add qidl-generated vmstate fields for rtc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: owasserm@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, Michael Roth , yamahata@valinux.co.jp, pbonzini@redhat.com, akong@redhat.com, afaerber@suse.de On 06/06/2012 02:38 AM, Anthony Liguori wrote: > On 06/05/2012 06:26 PM, Avi Kivity wrote: >> On 06/05/2012 04:00 AM, Michael Roth wrote: >>> Initial check-in of the qidl-generated vmstate fields for rtc. >>> >> >> Don't, please. > > As Mike said in another note, we want to keep the device schema in the > tree so we can determine when it changes in 'make check' and complain > loudly. > > But I think we need a better way to do this. Something like a 'make > schema-update' target that will regenerate schemas and prepare them for > checkin. Yes, that's much better. Also would be good to pretty-print them so that incremental changes are easy to spot using 'diff'. -- error compiling committee.c: too many arguments to function