From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 00/25] per-directory Makefile.objs snippets, limit vpath (ab)use
Date: Wed, 06 Jun 2012 17:23:27 +0800 [thread overview]
Message-ID: <4FCF218F.7000200@codemonkey.ws> (raw)
In-Reply-To: <1338964592-22223-1-git-send-email-pbonzini@redhat.com>
On 06/06/2012 02:36 PM, Paolo Bonzini wrote:
> Here is v2 of the nested Makefile patches. Thanks all for the enthusiasm!
>
> The main change is that rules can now be put in the per-directory snippets.
> This is done for op_helper.o already.
>
> Paolo
>
> v1->v2:
> do not call nested files "Makefile" (Andreas)
> do not create directories at configure time (Anthony)
> allow per-snippet rules, use it for op_helper.o (Blue Swirl)
> whitespace fixes (Blue Swirl)
> fix Xen (myself)
FWIW, with my patch, this seems to pass my basic sniff testing. I'll try to
apply a v3 quickly once you send it out.
Regards,
Anthony Liguori
>
> Paolo Bonzini (25):
> build: remove trace-nested-y
> build: do not sprinkle around GENERATED_HEADERS dependencies
> build: add rules for nesting
> build: move *-user/ objects to nested Makefile.objs
> build: move obj-TARGET-y variables to nested Makefile.objs
> build: move libobj-y variable to nested Makefile.objs
> build: move other target-*/ objects to nested Makefile.objs
> build: move rules for nesting to Makefile.objs
> build: put qom/ rules in a Makefile.objs file
> build: move block/ objects to nested Makefile.objs
> build: move net/ objects to nested Makefile.objs
> build: move fsdev/ objects to nested Makefile.objs
> build: move ui/ objects to nested Makefile.objs
> build: move audio/ objects to nested Makefile.objs
> build: move slirp/ objects to nested Makefile.objs
> build: move qapi/ objects to nested Makefile.objs
> build: move qga/ objects to nested Makefile.objs
> build: move target-independent hw/ objects to nested Makefile.objs
> build: convert libhw to nested Makefile.objs
> build: move per-target hw/ objects to nested Makefile.objs
> build: move device tree to per-target Makefile
> build: libcacard Makefile cleanups
> build: limit usage of vpath
> build: compile oslib-obj-y once
> build: do not create directories at configure time
>
> Makefile | 32 ++-
> Makefile.hw | 7 +-
> Makefile.objs | 317 ++++--------------------
> Makefile.target | 333 ++++----------------------
> audio/Makefile.objs | 14 ++
> block/Makefile.objs | 11 +
> bsd-user/Makefile.objs | 2 +
> configure | 55 ++---
> fsdev/Makefile.objs | 9 +
> hw/9pfs/Makefile.objs | 9 +
> hw/Makefile.objs | 165 +++++++++++++
> hw/alpha/Makefile.objs | 4 +
> hw/arm/Makefile.objs | 40 ++++
> hw/cris/Makefile.objs | 13 +
> hw/i386/Makefile.objs | 13 +
> hw/ide/Makefile.objs | 10 +
> hw/lm32/Makefile.objs | 23 ++
> hw/m68k/Makefile.objs | 4 +
> hw/microblaze/Makefile.objs | 14 ++
> hw/mips/Makefile.objs | 6 +
> hw/ppc/Makefile.objs | 32 +++
> hw/s390x/Makefile.objs | 3 +
> hw/sh4/Makefile.objs | 5 +
> hw/sparc/Makefile.objs | 8 +
> hw/sparc64/Makefile.objs | 4 +
> hw/usb/Makefile.objs | 13 +
> hw/xtensa/Makefile.objs | 5 +
> libcacard/Makefile | 17 +-
> linux-user/Makefile.objs | 7 +
> linux-user/arm/nwfpe/Makefile.objs | 2 +
> net/Makefile.objs | 12 +
> qapi/Makefile.objs | 3 +
> qga/Makefile.objs | 3 +
> qom/Makefile | 2 -
> qom/Makefile.objs | 4 +
> rules.mak | 40 ++++
> slirp/Makefile.objs | 3 +
> target-alpha/Makefile.objs | 3 +
> target-arm/Makefile.objs | 6 +
> arm-semi.c => target-arm/arm-semi.c | 0
> target-cris/Makefile.objs | 4 +
> target-i386/Makefile.objs | 7 +
> ioport-user.c => target-i386/ioport-user.c | 0
> target-lm32/Makefile.objs | 4 +
> target-m68k/Makefile.objs | 5 +
> m68k-semi.c => target-m68k/m68k-semi.c | 0
> target-microblaze/Makefile.objs | 4 +
> target-mips/Makefile.objs | 4 +
> target-ppc/Makefile.objs | 6 +
> target-s390x/Makefile.objs | 5 +
> target-sh4/Makefile.objs | 4 +
> target-sparc/Makefile.objs | 8 +
> target-unicore32/Makefile.objs | 4 +
> target-xtensa/Makefile.objs | 8 +
> xtensa-semi.c => target-xtensa/xtensa-semi.c | 0
> tests/Makefile | 1 -
> ui/Makefile.objs | 18 ++
> 57 files changed, 701 insertions(+), 634 deletions(-)
> create mode 100644 audio/Makefile.objs
> create mode 100644 block/Makefile.objs
> create mode 100644 bsd-user/Makefile.objs
> create mode 100644 fsdev/Makefile.objs
> create mode 100644 hw/9pfs/Makefile.objs
> create mode 100644 hw/Makefile.objs
> create mode 100644 hw/alpha/Makefile.objs
> create mode 100644 hw/arm/Makefile.objs
> create mode 100644 hw/cris/Makefile.objs
> create mode 100644 hw/i386/Makefile.objs
> create mode 100644 hw/ide/Makefile.objs
> create mode 100644 hw/lm32/Makefile.objs
> create mode 100644 hw/m68k/Makefile.objs
> create mode 100644 hw/microblaze/Makefile.objs
> create mode 100644 hw/mips/Makefile.objs
> create mode 100644 hw/ppc/Makefile.objs
> create mode 100644 hw/s390x/Makefile.objs
> create mode 100644 hw/sh4/Makefile.objs
> create mode 100644 hw/sparc/Makefile.objs
> create mode 100644 hw/sparc64/Makefile.objs
> create mode 100644 hw/usb/Makefile.objs
> create mode 100644 hw/xtensa/Makefile.objs
> create mode 100644 linux-user/Makefile.objs
> create mode 100644 linux-user/arm/nwfpe/Makefile.objs
> create mode 100644 net/Makefile.objs
> create mode 100644 qapi/Makefile.objs
> create mode 100644 qga/Makefile.objs
> delete mode 100644 qom/Makefile
> create mode 100644 qom/Makefile.objs
> create mode 100644 slirp/Makefile.objs
> create mode 100644 target-alpha/Makefile.objs
> create mode 100644 target-arm/Makefile.objs
> rename arm-semi.c => target-arm/arm-semi.c (100%)
> create mode 100644 target-cris/Makefile.objs
> create mode 100644 target-i386/Makefile.objs
> rename ioport-user.c => target-i386/ioport-user.c (100%)
> create mode 100644 target-lm32/Makefile.objs
> create mode 100644 target-m68k/Makefile.objs
> rename m68k-semi.c => target-m68k/m68k-semi.c (100%)
> create mode 100644 target-microblaze/Makefile.objs
> create mode 100644 target-mips/Makefile.objs
> create mode 100644 target-ppc/Makefile.objs
> create mode 100644 target-s390x/Makefile.objs
> create mode 100644 target-sh4/Makefile.objs
> create mode 100644 target-sparc/Makefile.objs
> create mode 100644 target-unicore32/Makefile.objs
> create mode 100644 target-xtensa/Makefile.objs
> rename xtensa-semi.c => target-xtensa/xtensa-semi.c (100%)
> create mode 100644 ui/Makefile.objs
>
prev parent reply other threads:[~2012-06-06 9:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-06 6:36 [Qemu-devel] [PATCH v2 00/25] per-directory Makefile.objs snippets, limit vpath (ab)use Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 01/25] build: remove trace-nested-y Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 02/25] build: do not sprinkle around GENERATED_HEADERS dependencies Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 03/25] build: add rules for nesting Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 04/25] build: move *-user/ objects to nested Makefile.objs Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 05/25] build: move obj-TARGET-y variables " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 06/25] build: move libobj-y variable " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 07/25] build: move other target-*/ objects " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 08/25] build: move rules for nesting to Makefile.objs Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 09/25] build: put qom/ rules in a Makefile.objs file Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 10/25] build: move block/ objects to nested Makefile.objs Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 11/25] build: move net/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 12/25] build: move fsdev/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 13/25] build: move ui/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 14/25] build: move audio/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 15/25] build: move slirp/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 16/25] build: move qapi/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 17/25] build: move qga/ " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 18/25] build: move target-independent hw/ objects to nested Makefiles Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 19/25] build: convert libhw to nested Makefile.objs Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 20/25] build: move per-target hw/ objects " Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 21/25] build: move device tree to per-target Makefile Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 22/25] build: libcacard Makefile cleanups Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 23/25] build: limit usage of vpath Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 24/25] build: compile oslib-obj-y once Paolo Bonzini
2012-06-06 6:36 ` [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time Paolo Bonzini
2012-06-06 8:58 ` Anthony Liguori
2012-06-06 11:54 ` Paolo Bonzini
2012-06-06 12:03 ` Peter Maydell
2012-06-06 12:16 ` Paolo Bonzini
2012-06-07 3:15 ` Anthony Liguori
2012-06-07 3:21 ` Eric Blake
2012-06-07 3:16 ` Anthony Liguori
2012-06-07 5:26 ` Paolo Bonzini
2012-06-07 5:28 ` Anthony Liguori
2012-06-06 9:23 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF218F.7000200@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).