From: Anthony Liguori <anthony@codemonkey.ws>
To: Yonit Halperin <yhalperi@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers
Date: Wed, 06 Jun 2012 19:05:44 +0800 [thread overview]
Message-ID: <4FCF3988.5020107@codemonkey.ws> (raw)
In-Reply-To: <20120606105447.GF16572@garlic.tlv.redhat.com>
On 06/06/2012 06:54 PM, Alon Levy wrote:
> On Wed, Jun 06, 2012 at 05:22:21PM +0800, Anthony Liguori wrote:
>> On 06/06/2012 05:10 PM, Yonit Halperin wrote:
>> Spice client migration has nothing to do with guest migration. Trying to
>
> I don't understand this POV. If it were a VNC connection instead of a
> Spice one would it make a difference?
Of course, I would say yes if it was VNC. Because the only possibly way I could
disagree with something Spice related is because I'm biased against it.
Give me the benefit of the doubt at least. More importantly, try to stop and
think about what I'm saying before you assume the anti-Spice brigade is coming
in to rain on your parade.
> If there is an active VNC client
> then it is there as a result of a user choosing to use it, so it should
> be treated as part of the user experience and not as something external.
> The experience from ignoring this and choosing to treat the remote
> console as an unrelated part is bound to be suboptimal.
Guest migration affects correctness!
If the Spice client is slow (even due to network lag) in responding to your
flush message, you will disrupt the guest and potentially drop network
connections and/or cause lockup detectors to trigger.
Migrating the Spice client is a UI feature. It has absolutely no affect no the
workloads that are running in the guest.
Impacting migration *correctness* in order to support a UI feature is
unacceptable especially when there are ways to achieve the same results without
having any impact on correctness.
We have had a simple rule with migration in QEMU. Nothing gets to impact
downtime with migration. No device gets magic hooks or anything like that. Go
read the TPM threads if you want to see another example of this.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2012-06-06 11:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 5:49 [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers Yonit Halperin
2012-06-05 5:49 ` [Qemu-devel] [RFC PATCH 1/5] notifiers: add support for async notifiers handlers Yonit Halperin
2012-06-05 8:36 ` Gerd Hoffmann
2012-06-05 5:49 ` [Qemu-devel] [RFC PATCH 2/5] migration: moving migration start code to a separated routine Yonit Halperin
2012-06-05 8:44 ` Gerd Hoffmann
2012-06-05 5:49 ` [Qemu-devel] [RFC PATCH 3/5] migration: moving migration completion " Yonit Halperin
2012-06-05 8:46 ` Gerd Hoffmann
2012-06-05 5:49 ` [Qemu-devel] [RFC PATCH 4/5] migration: replace migration state change notifier with async notifiers Yonit Halperin
2012-06-05 5:49 ` [Qemu-devel] [RFC PATCH 5/5] spice: turn spice "migration end" handler to be async Yonit Halperin
2012-06-05 11:59 ` [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers Anthony Liguori
2012-06-05 13:15 ` Gerd Hoffmann
2012-06-05 13:38 ` Eric Blake
2012-06-05 21:37 ` Anthony Liguori
2012-06-06 9:10 ` Yonit Halperin
2012-06-06 9:22 ` Anthony Liguori
2012-06-06 10:54 ` Alon Levy
2012-06-06 11:05 ` Anthony Liguori [this message]
2012-06-06 11:27 ` Alon Levy
2012-06-06 11:49 ` Anthony Liguori
2012-06-06 12:01 ` Yonit Halperin
2012-06-06 12:08 ` Anthony Liguori
2012-06-06 12:15 ` Alon Levy
2012-06-06 12:17 ` Anthony Liguori
2012-06-06 12:30 ` Alon Levy
2012-06-06 12:34 ` Anthony Liguori
2012-06-06 13:03 ` Gerd Hoffmann
2012-06-06 14:52 ` Alon Levy
2012-06-06 15:00 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF3988.5020107@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yhalperi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).