From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35925)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ScEpQ-0001mY-Mq
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 07:55:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ScEpL-00071t-9h
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 07:55:08 -0400
Received: from mail-pb0-f45.google.com ([209.85.160.45]:64248)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ScEpL-0006um-18
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 07:55:03 -0400
Received: by pbbro12 with SMTP id ro12so9624685pbb.4
	for <qemu-devel@nongnu.org>; Wed, 06 Jun 2012 04:55:00 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FCF450F.3000904@redhat.com>
Date: Wed, 06 Jun 2012 13:54:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1338964592-22223-1-git-send-email-pbonzini@redhat.com>
	<1338964592-22223-26-git-send-email-pbonzini@redhat.com>
	<4FCF1BCC.1090208@codemonkey.ws>
In-Reply-To: <4FCF1BCC.1090208@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories
 at configure time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001
> From: Anthony Liguori <aliguori@us.ibm.com>
> Date: Wed, 6 Jun 2012 16:57:00 +0800
> Subject: [PATCH] configure: ensure directory exists when creating symlink
> 
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  configure |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 07e3ff1..4a7f027 100755
> --- a/configure
> +++ b/configure
> @@ -42,6 +42,7 @@ compile_prog() {
>  # symbolically link $1 to $2.  Portable version of "ln -sf".
>  symlink() {
>    rm -rf "$2"
> +  mkdir -p `dirname $2`

Please leave the argument quoted, like

  dir=`dirname "$2`
  mkdir -p "$dir"

Otherwise looks good.  Do we need a v3?  This can just be committed
before 25/25 or even before all my patches, and that would be just what
I send.

Paolo

>    ln -s "$1" "$2"
>  }
>  
> @@ -3454,14 +3455,12 @@ if test -f ${config_host_ld}~ ; then
>  fi
>  
>  for d in libdis libdis-user; do
> -    mkdir -p $d
>      symlink "$source_path/Makefile.dis" "$d/Makefile"
>      echo > $d/config.mak
>  done
>  
>  # use included Linux headers
>  if test "$linux" = "yes" ; then
> -  mkdir -p linux-headers
>    case "$cpu" in
>    i386|x86_64)
>      symlink "$source_path/linux-headers/asm-x86" linux-headers/asm
> -- 1.7.5.4