From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey
Date: Wed, 06 Jun 2012 05:58:18 -0600 [thread overview]
Message-ID: <4FCF45DA.60809@redhat.com> (raw)
In-Reply-To: <4FCF0323.9070806@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On 06/06/2012 01:13 AM, Amos Kong wrote:
>>> Ho, I found another bug in my code, key in decimal or hexadecimal
>>> format is not supported. I will fix it.
>>
>> How do you plan to support decimal in QMP?
>
> In old do_sendkey(), only key-name and hexadecimal were supported,
> the description needs to be fixed.
>
>
> It seems we can only support key-name for QMP, and support
> key-name/hexadecimal
> for HMP. Is it acceptable?
Yes, that was my argument for bare minimum support - anyone using QMP
(like libvirt) will have to be smart enough to use key-name only, while
anyone using HMP will be able to use hex because HMP will convert hex to
key-name at the appropriate time before calling into QMP.
Of course, being able to support hex from QMP would be a nice feature,
but I'm not sure how to add it in.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-06-06 11:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 22:54 [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 1/6] qerror: add QERR_OVERFLOW Amos Kong
2012-06-04 5:27 ` Anthony Liguori
2012-06-05 14:29 ` [Qemu-devel] [PATCH v2 1/6] qerror: add MAX_KEYCODES 16 Amos Kong
[not found] ` <4FD0326F.3010806@redhat.com>
[not found] ` <20120611140642.06be2ee8@doriath.home>
[not found] ` <4FD62827.4060900@us.ibm.com>
[not found] ` <20120611142546.66871522@doriath.home>
2012-06-14 10:20 ` Amos Kong
2012-06-15 7:46 ` Amos Kong
2012-06-15 7:57 ` Gerd Hoffmann
2012-06-15 13:35 ` Luiz Capitulino
2012-06-18 15:30 ` Amos Kong
2012-06-19 9:52 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 2/6] fix doc of using raw values with sendkey Amos Kong
2012-06-06 18:16 ` Luiz Capitulino
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 3/6] rename keyname '<' to 'less' Amos Kong
2012-06-06 18:22 ` Luiz Capitulino
2012-06-06 23:12 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 4/6] hmp: rename arguments Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 5/6] qapi: generate list struct and visit_list for enum Amos Kong
2012-06-05 15:01 ` Amos Kong
2012-06-06 18:40 ` Luiz Capitulino
2012-06-07 0:26 ` Michael Roth
2012-06-07 2:52 ` Amos Kong
2012-06-11 17:00 ` Luiz Capitulino
2012-06-07 0:15 ` Michael Roth
2012-06-07 3:33 ` Amos Kong
2012-06-01 22:54 ` [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey Amos Kong
2012-06-04 17:09 ` Eric Blake
2012-06-05 14:55 ` Amos Kong
2012-06-05 15:05 ` Eric Blake
2012-06-06 7:13 ` Amos Kong
2012-06-06 11:58 ` Eric Blake [this message]
2012-06-07 4:51 ` Anthony Liguori
2012-06-07 13:08 ` Eric Blake
2012-06-01 23:03 ` [Qemu-devel] [PATCH v2 0/6] convert sendkey to qapi Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCF45DA.60809@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).