From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScEse-0002sW-Gw for qemu-devel@nongnu.org; Wed, 06 Jun 2012 07:58:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScEsX-0007dl-L3 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 07:58:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6393) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScEsX-0007dD-Cc for qemu-devel@nongnu.org; Wed, 06 Jun 2012 07:58:21 -0400 Message-ID: <4FCF45DA.60809@redhat.com> Date: Wed, 06 Jun 2012 05:58:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <20a919f7-f1f2-4fdd-b27c-e126364d9040@zmail13.collab.prod.int.phx2.redhat.com> <4FCE2027.5060002@redhat.com> <4FCF0323.9070806@redhat.com> In-Reply-To: <4FCF0323.9070806@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigDF08C9A087A06E1581CCFD38" Subject: Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDF08C9A087A06E1581CCFD38 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/06/2012 01:13 AM, Amos Kong wrote: >>> Ho, I found another bug in my code, key in decimal or hexadecimal >>> format is not supported. I will fix it. >> >> How do you plan to support decimal in QMP? >=20 > In old do_sendkey(), only key-name and hexadecimal were supported, > the description needs to be fixed. >=20 >=20 > It seems we can only support key-name for QMP, and support > key-name/hexadecimal > for HMP. Is it acceptable? Yes, that was my argument for bare minimum support - anyone using QMP (like libvirt) will have to be smart enough to use key-name only, while anyone using HMP will be able to use hex because HMP will convert hex to key-name at the appropriate time before calling into QMP. Of course, being able to support hex from QMP would be a nice feature, but I'm not sure how to add it in. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigDF08C9A087A06E1581CCFD38 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPz0XaAAoJEKeha0olJ0NqOhAH/j1umbRqykIxLPP901ke3PvJ eiqaCpobnmjgK36qXGNJDwFsinm+TkSRfGalrCzLjaXaVmUxWBRM8BKdMPAAADcd Mj4JjPkBg7uXeyWuCJ8lrWfHYQOFBt11LZaMC098zJ5ORY5Yp4/KG1oHsbsMj+UW DvMLSOs8IHHUPPVgehAI2tHnHc3AxY4R2Adh8yxq7AC4MoUnJUnZVZSOEpHYwfdB APQ760zQ4WIiynd9ylTdYzEHJmyfsXa28fMCYHRsOiKBH3WMEHGax8MYP/PLrOPD m50Ht86BnUCJSdPyFHXEGubpARShMnx2mBnzZ5Qi0hsH4p+syuz8K8jcQeAUl9E= =LrQu -----END PGP SIGNATURE----- --------------enigDF08C9A087A06E1581CCFD38--