From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50590) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScFRU-0002R5-9C for qemu-devel@nongnu.org; Wed, 06 Jun 2012 08:34:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScFRP-0000mJ-JQ for qemu-devel@nongnu.org; Wed, 06 Jun 2012 08:34:27 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:59605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScFRP-0000li-Cr for qemu-devel@nongnu.org; Wed, 06 Jun 2012 08:34:23 -0400 Received: by pbbro12 with SMTP id ro12so9675063pbb.4 for ; Wed, 06 Jun 2012 05:34:21 -0700 (PDT) Message-ID: <4FCF4E47.3040707@codemonkey.ws> Date: Wed, 06 Jun 2012 20:34:15 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1338875386-21051-1-git-send-email-yhalperi@redhat.com> <4FCDF49E.6090006@codemonkey.ws> <4FCE067E.5030903@redhat.com> <4FCF1E70.3030703@redhat.com> <4FCF214D.8060001@codemonkey.ws> <4FCF46B0.1010905@redhat.com> <4FCF4848.9010005@codemonkey.ws> <20120606121516.GI16572@garlic.tlv.redhat.com> <4FCF4A59.2060100@codemonkey.ws> <20120606123027.GK16572@garlic.tlv.redhat.com> In-Reply-To: <20120606123027.GK16572@garlic.tlv.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 0/5] asynchronous migration state change handlers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Yonit Halperin , aliguori@us.ibm.com, Gerd Hoffmann , qemu-devel@nongnu.org On 06/06/2012 08:30 PM, Alon Levy wrote: > On Wed, Jun 06, 2012 at 08:17:29PM +0800, Anthony Liguori wrote: >> On 06/06/2012 08:15 PM, Alon Levy wrote: >>> On Wed, Jun 06, 2012 at 08:08:40PM +0800, Anthony Liguori wrote: >>>> On 06/06/2012 08:01 PM, Yonit Halperin wrote: >>>>> On 06/06/2012 12:22 PM, Anthony Liguori wrote: >>>>>> >>>>>> So send a QMP event and call it a day. >>>>>> >>>>> Using a QMP event is making spice seamless migration dependent on libvirt >>>>> version. >>>> >>>> That is not an acceptable justification. >>> >>> To let spice know that libvirt doesn't support the new event would >>> require libvirt capabilities advertisement to qemu. Is that acceptable? >> >> I literally have danpb's event introspection patches from Luiz's PULL >> request testing on my system right now to be pushed. > this?: [PATCH 29/29] Add 'query-events' command to QMP to query async events > > This is about libvirt getting qemu's event list. I am talking about qemu > getting libvirt to say "we support event SPICE_MIGRATE_DONE". i.e. Yet > another capability negotiation, during the handshake QMP phase. qemu -spice foo,seamless-migration=on Doesn't seem that hard to me... Regards, Anthony Liguori