From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScFsM-0002VX-1i for qemu-devel@nongnu.org; Wed, 06 Jun 2012 09:02:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScFsI-00006k-P0 for qemu-devel@nongnu.org; Wed, 06 Jun 2012 09:02:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScFsI-00006C-HE for qemu-devel@nongnu.org; Wed, 06 Jun 2012 09:02:10 -0400 Message-ID: <4FCF5512.9000704@redhat.com> Date: Wed, 06 Jun 2012 15:03:14 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1337683555-13301-1-git-send-email-lersek@redhat.com> <4FCE7684.2070206@redhat.com> In-Reply-To: <4FCE7684.2070206@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, =?ISO-8859-15?Q?Andreas_F=E4rber?= , Michael Roth On 06/05/12 23:13, Paolo Bonzini wrote: > There is one small mistake that needs to be addressed in a v2, so it > would be great if you could use the int*_t visitors to avoid > complicating the code with range checks. OK so this is what I see: (a) add < 0 checks to and include it in the series, (b) make all Netdev integer types as strict as possible, remove superfluous checks, (c) render NetLegacy::name optional. How do I lay out (a)? Should I include the patch verbatim first (with proper From: and Signed-off-by: lines) and then modify it in a small followup, or squash those two and... what? :) Thanks, Laszlo