From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:32947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScGvd-0002q1-Jq for qemu-devel@nongnu.org; Wed, 06 Jun 2012 10:09:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScGvX-0008Py-Pi for qemu-devel@nongnu.org; Wed, 06 Jun 2012 10:09:41 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:35491) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScGvX-0008PO-Gm for qemu-devel@nongnu.org; Wed, 06 Jun 2012 10:09:35 -0400 Received: by dadv2 with SMTP id v2so9602660dad.4 for ; Wed, 06 Jun 2012 07:09:32 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FCF6496.4070104@redhat.com> Date: Wed, 06 Jun 2012 16:09:26 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1337683555-13301-1-git-send-email-lersek@redhat.com> <4FCE7684.2070206@redhat.com> <4FCF5512.9000704@redhat.com> In-Reply-To: <4FCF5512.9000704@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/16] introduce OptsVisitor, rebase -net/-netdev parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Michael Roth , qemu-devel@nongnu.org, =?ISO-8859-15?Q?Andreas_F=E4rber?= Il 06/06/2012 15:03, Laszlo Ersek ha scritto: > OK so this is what I see: > > (a) add < 0 checks to and > include it in the series, > (b) make all Netdev integer types as strict as possible, remove > superfluous checks, > (c) render NetLegacy::name optional. Yep. > How do I lay out (a)? Should I include the patch verbatim first (with > proper From: and Signed-off-by: lines) and then modify it in a small > followup or squash those two and... what? :) As you prefer. In either case leave the From to Michael and add your Signed-off-by, which I guess is what you meant by "proper". Paolo