From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46784)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScONY-00065P-0g
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:07:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScONV-0000bf-LO
	for qemu-devel@nongnu.org; Wed, 06 Jun 2012 18:06:59 -0400
Message-ID: <4FCFD476.6040204@suse.de>
Date: Thu, 07 Jun 2012 00:06:46 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339017061-7358-1-git-send-email-mjt@msgid.tls.msk.ru>
In-Reply-To: <1339017061-7358-1-git-send-email-mjt@msgid.tls.msk.ru>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it
 first and reinventing it later
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Corey Bryant <coreyb@linux.vnet.ibm.com>, Richa Marwaha <rmarwah@linux.vnet.ibm.com>, qemu-stable@nongnu.org, qemu-devel@nongnu.org

Am 06.06.2012 23:11, schrieb Michael Tokarev:
> Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 "Add basic version
> of bridge helper" put the bridge helper executable into a fixed
> ${prefix}/libexec/ location, instead of using ${libexecdir} for
> this.  At the same time, --libexecdir is being happily ignored
> by ./configure.  Even more, the same patch sets unused $libexecdir
> variable in the generated config-host.mak, and uses fixed string
> (\${prefix}/libexecdir) for the bridge helper binary.
>=20
> Fix this braindamage by introducing $libexecdir variable, using
> it for the bridge helper binary, and recognizing --libexecdir.
>=20
> This patch is applicable to stable-1.1.
>=20
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> Cc: Corey Bryant <coreyb@linux.vnet.ibm.com>
> Cc: Richa Marwaha <rmarwah@linux.vnet.ibm.com>
> Cc: qemu-stable@nongnu.org

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

I noticed the lack of this and just passed libexecdir=3D to make as a
workaround for our openSUSE package.

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg