qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later
Date: Thu, 07 Jun 2012 00:21:09 +0200	[thread overview]
Message-ID: <4FCFD7D5.1030909@suse.de> (raw)
In-Reply-To: <4FCFD5BE.7040506@msgid.tls.msk.ru>

Am 07.06.2012 00:12, schrieb Michael Tokarev:
> On 07.06.2012 02:06, Andreas Färber wrote:
>> Am 06.06.2012 23:11, schrieb Michael Tokarev:
> []
>> Reviewed-by: Andreas Färber <afaerber@suse.de>
>>
>> I noticed the lack of this and just passed libexecdir= to make as a
>> workaround for our openSUSE package.
> 
> Thank you for your review.  However, passing libexecdir= to make
> wont work,

Trust me, it does. Otherwise our package build would still fail since
our %_libexecdir is /usr/lib.

See Makefile, that one actually uses $(libexecdir):

Makefile:       $(INSTALL_DIR) "$(DESTDIR)$(libexecdir)"
Makefile:       $(INSTALL_PROG) $(STRIP_OPT) $(HELPERS-y)
"$(DESTDIR)$(libexecdir)"

Yes, it is a mess. :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-06-06 22:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-06 21:11 [Qemu-devel] [PATCH] use --libexecdir instead of ignoring it first and reinventing it later Michael Tokarev
2012-06-06 22:06 ` Andreas Färber
2012-06-06 22:12   ` Michael Tokarev
2012-06-06 22:21     ` Andreas Färber [this message]
2012-06-06 22:23       ` Michael Tokarev
2012-06-06 22:36         ` Andreas Färber
2012-06-06 22:50           ` Michael Tokarev
2012-06-06 23:20           ` Bruce Rogers
2012-06-07  4:22           ` Bo Yang
2012-06-07 15:17 ` Corey Bryant
2012-08-16 14:46 ` Andreas Färber
2012-09-03 15:49   ` [Qemu-devel] [PATCH for-1.2] " Andreas Färber
2012-09-10 23:01 ` [Qemu-devel] [PATCH] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCFD7D5.1030909@suse.de \
    --to=afaerber@suse.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).