From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScTIL-0005WL-Bq for qemu-devel@nongnu.org; Wed, 06 Jun 2012 23:21:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScTIJ-0006oe-Ch for qemu-devel@nongnu.org; Wed, 06 Jun 2012 23:21:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:19295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScTIJ-0006oS-4d for qemu-devel@nongnu.org; Wed, 06 Jun 2012 23:21:55 -0400 Message-ID: <4FD01E4D.70701@redhat.com> Date: Wed, 06 Jun 2012 21:21:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1338964592-22223-1-git-send-email-pbonzini@redhat.com> <1338964592-22223-26-git-send-email-pbonzini@redhat.com> <4FCF1BCC.1090208@codemonkey.ws> <4FCF450F.3000904@redhat.com> <4FCF4A2C.7050601@redhat.com> <4FD01CD3.8000102@codemonkey.ws> In-Reply-To: <4FD01CD3.8000102@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigADB8C572026DB3AAC894D699" Subject: Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Paolo Bonzini , qemu-devel@nongnu.org, Peter Maydell This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigADB8C572026DB3AAC894D699 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/06/2012 09:15 PM, Anthony Liguori wrote: > On 06/06/2012 08:16 PM, Paolo Bonzini wrote: >> Il 06/06/2012 14:03, Peter Maydell ha scritto: >>> Can we use >>> mkdir -p "$(dirname "$2")" >>> >>> or are we still trying to be compatible with some non-POSIX >>> shell from the dawn of time? >> >> Looks like we can, there are other occurrences of $() in configure. >=20 > I saw that too, but I thought $() was a bash-ism. $() is required by POSIX. The problem is that Solaris' /bin/sh does not understand $(), since it is not a POSIX shell. If you take care to sanitize shell execution into a sane shell (yes, it is possible to write configure scripts that re-execute themselves under a better shell than /bin/sh), then using $() can be one of the decision points on whether a better shell has been found. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigADB8C572026DB3AAC894D699 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP0B5NAAoJEKeha0olJ0Nq4DEIAJsHTEv2wUF7FoUDB/G2NBGM fXhxCes6c68Q8LyYwvMbSYTeczgkwTP8bk3et84lhU0SJ//J3kBn8WbXFZkpQIou IK63nKJuTSAzIIdJHub8t4YHqgxu2zCw03Tg15v+otpL2RoyopvG+qAAFhEdkzov wMQL6qh769xZQql/0i5CngwtJxMlMsots1AHQZEc3rCUcGAOxgosb5W78NgsE++d vlHEsLUM+A5J6x6+I+Ym58MfaGwEsII/GBXu8NrmzaTNBsp2r8Jsnf84LqZRE+0P DlOEKgmrsZ9RWFPpRE0qy5ujaYr4DNpycFOSytqCMukJZM0DqRaKvXfsugNp2G0= =4RXG -----END PGP SIGNATURE----- --------------enigADB8C572026DB3AAC894D699--