From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScUhZ-0006zY-10 for qemu-devel@nongnu.org; Thu, 07 Jun 2012 00:52:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScUhX-0007UN-9A for qemu-devel@nongnu.org; Thu, 07 Jun 2012 00:52:04 -0400 Received: from e36.co.us.ibm.com ([32.97.110.154]:50636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScUhX-0007UF-2X for qemu-devel@nongnu.org; Thu, 07 Jun 2012 00:52:03 -0400 Received: from /spool/local by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 6 Jun 2012 22:51:59 -0600 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id D7FFA1FF001B for ; Thu, 7 Jun 2012 04:51:51 +0000 (WET) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q574pPOL106712 for ; Wed, 6 Jun 2012 22:51:35 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q574p9cU011078 for ; Wed, 6 Jun 2012 22:51:10 -0600 Message-ID: <4FD0333B.7060001@us.ibm.com> Date: Thu, 07 Jun 2012 12:51:07 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <20a919f7-f1f2-4fdd-b27c-e126364d9040@zmail13.collab.prod.int.phx2.redhat.com> <4FCE2027.5060002@redhat.com> <4FCF0323.9070806@redhat.com> <4FCF45DA.60809@redhat.com> In-Reply-To: <4FCF45DA.60809@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Amos Kong , qemu-devel@nongnu.org, lcapitulino@redhat.com On 06/06/2012 07:58 PM, Eric Blake wrote: > On 06/06/2012 01:13 AM, Amos Kong wrote: > >>>> Ho, I found another bug in my code, key in decimal or hexadecimal >>>> format is not supported. I will fix it. >>> >>> How do you plan to support decimal in QMP? >> >> In old do_sendkey(), only key-name and hexadecimal were supported, >> the description needs to be fixed. >> > >> >> It seems we can only support key-name for QMP, and support >> key-name/hexadecimal >> for HMP. Is it acceptable? > > Yes, that was my argument for bare minimum support - anyone using QMP > (like libvirt) will have to be smart enough to use key-name only, while > anyone using HMP will be able to use hex because HMP will convert hex to > key-name at the appropriate time before calling into QMP. > > Of course, being able to support hex from QMP would be a nice feature, > but I'm not sure how to add it in. Why is it a nice feature? I don't quite understand why anyone would want to use hex actually... You would have to convert from whatever symbolic code you're using to QEMU's hex value so why not just stay in symbolic representation. Regards, Anthony Liguori >