From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScUl2-000166-VI for qemu-devel@nongnu.org; Thu, 07 Jun 2012 00:55:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScUl1-0007vT-8a for qemu-devel@nongnu.org; Thu, 07 Jun 2012 00:55:40 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:46138) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScUl1-0007vL-4A for qemu-devel@nongnu.org; Thu, 07 Jun 2012 00:55:39 -0400 Received: by obbwd20 with SMTP id wd20so391203obb.4 for ; Wed, 06 Jun 2012 21:55:37 -0700 (PDT) Message-ID: <4FD03443.9000805@redhat.com> Date: Thu, 07 Jun 2012 12:55:31 +0800 From: Anthony Liguori MIME-Version: 1.0 References: <1339034542-8960-1-git-send-email-pbonzini@redhat.com> <1339034542-8960-4-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339034542-8960-4-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/3] qmp: do not include monitor.h from qapi-types-core.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, lcapitulino@redhat.com On 06/07/2012 10:02 AM, Paolo Bonzini wrote: > The comment is stale, monitor.h is not needed anymore (only qerror.h > is, because it contains the schema for errors). > > Signed-off-by: Paolo Bonzini > --- > qapi/qapi-types-core.h | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/qapi/qapi-types-core.h b/qapi/qapi-types-core.h > index 27e6be0..f781fc3 100644 > --- a/qapi/qapi-types-core.h > +++ b/qapi/qapi-types-core.h > @@ -16,8 +16,6 @@ > > #include "qemu-common.h" > #include "error.h" > - > -/* FIXME this is temporary until we remove middle mode */ > -#include "monitor.h" > +#include "qerror.h" Middle mode generates signatures that contain a 'Monitor *'. qmp-commands.h includes qmp-types which only includes qmp-types-core.h Without having a #include "monitor.h" here, qmp-commands.h is relying on something else including monitor.h before including qmp-commands.h I guess you could push the monitor.h include to qmp-commands.h but the point of qmp-types-core was to avoid having to add #includes to the code generator. Regards, Anthony Liguori > > #endif