From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34437) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScVFf-0008OR-U5 for qemu-devel@nongnu.org; Thu, 07 Jun 2012 01:27:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScVFd-0005EJ-O2 for qemu-devel@nongnu.org; Thu, 07 Jun 2012 01:27:19 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:44364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScVFd-0005E0-FE for qemu-devel@nongnu.org; Thu, 07 Jun 2012 01:27:17 -0400 Received: by dadv2 with SMTP id v2so384944dad.4 for ; Wed, 06 Jun 2012 22:27:15 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FD03B6D.8080206@redhat.com> Date: Thu, 07 Jun 2012 07:26:05 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1338964592-22223-1-git-send-email-pbonzini@redhat.com> <1338964592-22223-26-git-send-email-pbonzini@redhat.com> <4FCF1BCC.1090208@codemonkey.ws> <4FCF450F.3000904@redhat.com> <4FD01CFD.50603@codemonkey.ws> In-Reply-To: <4FD01CFD.50603@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Il 07/06/2012 05:16, Anthony Liguori ha scritto: > On 06/06/2012 07:54 PM, Paolo Bonzini wrote: >>> From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001 >>> From: Anthony Liguori >>> Date: Wed, 6 Jun 2012 16:57:00 +0800 >>> Subject: [PATCH] configure: ensure directory exists when creating >>> symlink >>> >>> Signed-off-by: Anthony Liguori >>> --- >>> configure | 3 +-- >>> 1 files changed, 1 insertions(+), 2 deletions(-) >>> >>> diff --git a/configure b/configure >>> index 07e3ff1..4a7f027 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -42,6 +42,7 @@ compile_prog() { >>> # symbolically link $1 to $2. Portable version of "ln -sf". >>> symlink() { >>> rm -rf "$2" >>> + mkdir -p `dirname $2` >> >> Please leave the argument quoted, like >> >> dir=`dirname "$2` >> mkdir -p "$dir" >> >> Otherwise looks good. Do we need a v3? This can just be committed >> before 25/25 or even before all my patches, and that would be just what >> I send. > > Unfortunately, this conflicts pretty badly with Andreas' QOM CPU > series. Could you rebase and send out a v3? No, it's the dumping series from Luiz. I'll send a v3 as a pull request. Paolo