Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories at configure time

[Anthony Liguori <anthony@codemonkey.ws>]

On 06/07/2012 01:26 PM, Paolo Bonzini wrote:
> Il 07/06/2012 05:16, Anthony Liguori ha scritto:
>> On 06/06/2012 07:54 PM, Paolo Bonzini wrote:
>>>>    From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001
>>>> From: Anthony Liguori<aliguori@us.ibm.com>
>>>> Date: Wed, 6 Jun 2012 16:57:00 +0800
>>>> Subject: [PATCH] configure: ensure directory exists when creating
>>>> symlink
>>>>
>>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>>> ---
>>>>    configure |    3 +--
>>>>    1 files changed, 1 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/configure b/configure
>>>> index 07e3ff1..4a7f027 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -42,6 +42,7 @@ compile_prog() {
>>>>    # symbolically link $1 to $2.  Portable version of "ln -sf".
>>>>    symlink() {
>>>>      rm -rf "$2"
>>>> +  mkdir -p `dirname $2`
>>>
>>> Please leave the argument quoted, like
>>>
>>>     dir=`dirname "$2`
>>>     mkdir -p "$dir"
>>>
>>> Otherwise looks good.  Do we need a v3?  This can just be committed
>>> before 25/25 or even before all my patches, and that would be just what
>>> I send.
>>
>> Unfortunately, this conflicts pretty badly with Andreas' QOM CPU
>> series.  Could you rebase and send out a v3?
>
> No, it's the dumping series from Luiz.  I'll send a v3 as a pull request.

Okay, thanks.

Regards,

Anthony Liguori

>
> Paolo
>