From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34619)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ScVGb-0000et-VV
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 01:28:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ScVGa-0005JJ-6Q
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 01:28:17 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:52487)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ScVGa-0005J7-2C
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 01:28:16 -0400
Received: by yhoo21 with SMTP id o21so178187yho.4
	for <qemu-devel@nongnu.org>; Wed, 06 Jun 2012 22:28:14 -0700 (PDT)
Message-ID: <4FD03BEA.7050703@codemonkey.ws>
Date: Thu, 07 Jun 2012 13:28:10 +0800
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1338964592-22223-1-git-send-email-pbonzini@redhat.com>
	<1338964592-22223-26-git-send-email-pbonzini@redhat.com>
	<4FCF1BCC.1090208@codemonkey.ws> <4FCF450F.3000904@redhat.com>
	<4FD01CFD.50603@codemonkey.ws> <4FD03B6D.8080206@redhat.com>
In-Reply-To: <4FD03B6D.8080206@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 25/25] build: do not create directories
 at configure time
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 06/07/2012 01:26 PM, Paolo Bonzini wrote:
> Il 07/06/2012 05:16, Anthony Liguori ha scritto:
>> On 06/06/2012 07:54 PM, Paolo Bonzini wrote:
>>>>    From e0e6e5b689cbcb782bca8f158fad89b3389e9e11 Mon Sep 17 00:00:00 2001
>>>> From: Anthony Liguori<aliguori@us.ibm.com>
>>>> Date: Wed, 6 Jun 2012 16:57:00 +0800
>>>> Subject: [PATCH] configure: ensure directory exists when creating
>>>> symlink
>>>>
>>>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>>>> ---
>>>>    configure |    3 +--
>>>>    1 files changed, 1 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/configure b/configure
>>>> index 07e3ff1..4a7f027 100755
>>>> --- a/configure
>>>> +++ b/configure
>>>> @@ -42,6 +42,7 @@ compile_prog() {
>>>>    # symbolically link $1 to $2.  Portable version of "ln -sf".
>>>>    symlink() {
>>>>      rm -rf "$2"
>>>> +  mkdir -p `dirname $2`
>>>
>>> Please leave the argument quoted, like
>>>
>>>     dir=`dirname "$2`
>>>     mkdir -p "$dir"
>>>
>>> Otherwise looks good.  Do we need a v3?  This can just be committed
>>> before 25/25 or even before all my patches, and that would be just what
>>> I send.
>>
>> Unfortunately, this conflicts pretty badly with Andreas' QOM CPU
>> series.  Could you rebase and send out a v3?
>
> No, it's the dumping series from Luiz.  I'll send a v3 as a pull request.

Okay, thanks.

Regards,

Anthony Liguori

>
> Paolo
>