From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScbLo-0007NK-J9 for qemu-devel@nongnu.org; Thu, 07 Jun 2012 07:58:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScbLm-0001vO-TP for qemu-devel@nongnu.org; Thu, 07 Jun 2012 07:58:04 -0400 Received: from cantor2.suse.de ([195.135.220.15]:56690 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScbLm-0001vE-N8 for qemu-devel@nongnu.org; Thu, 07 Jun 2012 07:58:02 -0400 Message-ID: <4FD09741.4070103@suse.de> Date: Thu, 07 Jun 2012 13:57:53 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <93f616330f3e8c5ae27d50d27bda9a5a8804d3aa.1339044751.git.peter.crosthwaite@petalogix.com> In-Reply-To: <93f616330f3e8c5ae27d50d27bda9a5a8804d3aa.1339044751.git.peter.crosthwaite@petalogix.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 3/4] vl.c: allow for reapeated -sd arguments List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Peter A. G. Crosthwaite" Cc: Kevin Wolf , peter.maydell@linaro.org, i.mitsyanko@samsung.com, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, edgar.iglesias@gmail.com, m.kozlov@samsung.com, john.williams@petalogix.com Speaking of typos in the cover letter, "repeated" and... Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite: > Allows for repeating of -sd arugments in the same way -pflash and -mtdb= lock ..."arguments". > can be repeated. >=20 > Signed-off-by: Peter A. G. Crosthwaite Multiple SD controllers indeed need to be supported, patch looks good. Andreas > --- > vl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) >=20 > diff --git a/vl.c b/vl.c > index 23ab3a3..a381e90 100644 > --- a/vl.c > +++ b/vl.c > @@ -2437,7 +2437,7 @@ int main(int argc, char **argv, char **envp) > drive_add(IF_MTD, -1, optarg, MTD_OPTS); > break; > case QEMU_OPTION_sd: > - drive_add(IF_SD, 0, optarg, SD_OPTS); > + drive_add(IF_SD, -1, optarg, SD_OPTS); > break; > case QEMU_OPTION_pflash: > drive_add(IF_PFLASH, -1, optarg, PFLASH_OPTS); --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg