From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47194) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SccSR-0002UQ-Gs for qemu-devel@nongnu.org; Thu, 07 Jun 2012 09:09:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SccSM-00037d-LM for qemu-devel@nongnu.org; Thu, 07 Jun 2012 09:08:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SccSM-00036p-Ds for qemu-devel@nongnu.org; Thu, 07 Jun 2012 09:08:54 -0400 Message-ID: <4FD0A7E3.4000209@redhat.com> Date: Thu, 07 Jun 2012 07:08:51 -0600 From: Eric Blake MIME-Version: 1.0 References: <20a919f7-f1f2-4fdd-b27c-e126364d9040@zmail13.collab.prod.int.phx2.redhat.com> <4FCE2027.5060002@redhat.com> <4FCF0323.9070806@redhat.com> <4FCF45DA.60809@redhat.com> <4FD0333B.7060001@us.ibm.com> In-Reply-To: <4FD0333B.7060001@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0E750D3E9006672FD8D150A1" Subject: Re: [Qemu-devel] [PATCH v2 6/6] qapi: convert sendkey List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Amos Kong , qemu-devel@nongnu.org, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0E750D3E9006672FD8D150A1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/06/2012 10:51 PM, Anthony Liguori wrote: >> Of course, being able to support hex from QMP would be a nice feature,= >> but I'm not sure how to add it in. >=20 > Why is it a nice feature? Because libvirt already allows users to pass in integers instead of symbolic names. Providing integer support in QMP would let the path be passthrough, instead of libvirt doing a reverse lookup to convert integer to symbol just to call QMP for qemu to do a lookup from symbol back to integer. >=20 > I don't quite understand why anyone would want to use hex actually...=20 > You would have to convert from whatever symbolic code you're using to > QEMU's hex value so why not just stay in symbolic representation. Staying just symbolic is fine - remember, I already stated that libvirt already has a lookup table to convert between several different keycode sets already, and Dan Berrange has already proposed sharing that table with qemu. And settling on symbolic as the only interface, even if it is less efficient than integer passthrough, is at least easier to maintai= n. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0E750D3E9006672FD8D150A1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP0KfjAAoJEKeha0olJ0NqdCAH/0ChGgfcAEQopmPWxVKjJOvv 9Pkj7jAE0o9M55TVruPOV7giCYjuZCVqPLi3nHVKxFr3IWalYGEOjO/t9+8crXmF zF5alujR4zoN8LPW6Oq3VgIlof6786ALVWtxFlCLb3Y22lZQCKA33yLWPa3sDO0J b9mnQZdtWSWZvm6MzFfW9OX1L+0R4HJPuzjDjRXnwb7EFluMdTxiAUCrLi3/MBhl hccuJqqsbZwa80CMDD+7kjSX8MumxOH/AQe7hWvsPlzerUxOhDBVrrvrjcnWCu0m eGqWkip+kqsRHAIxRZbSyQPrASDg+dSG7euPq9PXEfZFngAhdRkRRol7AvoAcnc= =rSIM -----END PGP SIGNATURE----- --------------enig0E750D3E9006672FD8D150A1--