From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57499)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Scd2S-0002Vc-7n
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 09:46:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Scd2L-0004mk-Ti
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 09:46:11 -0400
Received: from cantor2.suse.de ([195.135.220.15]:37016 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Scd2L-0004jf-Mw
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 09:46:05 -0400
Message-ID: <4FD0B097.7030106@suse.de>
Date: Thu, 07 Jun 2012 15:45:59 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1325175596-5807-1-git-send-email-mark.langsdorf@calxeda.com>
	<1325175596-5807-6-git-send-email-mark.langsdorf@calxeda.com>
In-Reply-To: <1325175596-5807-6-git-send-email-mark.langsdorf@calxeda.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v5 5/5] add L2x0/PL310 cache controller
	device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark Langsdorf <mark.langsdorf@calxeda.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, rob.herring@calxeda.com, Paolo Bonzini <pbonzini@redhat.com>

Am 29.12.2011 17:19, schrieb Mark Langsdorf:
> From: Rob Herring <rob.herring@calxeda.com>
>=20
> This is just a dummy device for ARM L2 cache controllers, based on the
> pl310. The cache type parameter can be defined by a property value
> and has a meaningful default.
>=20
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@calxeda.com>

> diff --git a/hw/arm_l2x0.c b/hw/arm_l2x0.c
> new file mode 100644
> index 0000000..ba106f1
> --- /dev/null
> +++ b/hw/arm_l2x0.c
[...]
> +static SysBusDeviceInfo l2x0_info =3D {
> +    .init =3D l2x0_priv_init,
> +    .qdev.name =3D "l2x0",
> +    .qdev.size =3D sizeof(l2x0_state),
> +    .qdev.vmsd =3D &vmstate_l2x0,
> +    .qdev.no_user =3D 1,
> +    .qdev.props =3D (Property[]) {
> +        DEFINE_PROP_UINT32("type", l2x0_state, cache_type, 0x1c100100)=
,

Mark, this "type" property conflicts with a QOM refactoring by Paolo.
Mind if we rename it to "cache-type"? It always has its default value in
upstream.

Thanks,
Andreas

> +        DEFINE_PROP_END_OF_LIST(),
> +    },
> +    .qdev.reset =3D l2x0_priv_reset,
> +};
> +
> +static void l2x0_register_device(void)
> +{
> +    sysbus_register_withprop(&l2x0_info);
> +}
> +
> +device_init(l2x0_register_device)
> +


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg