From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49057)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScipJ-0007Uo-Bg
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 15:57:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScipH-0001N5-HQ
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 15:57:00 -0400
Received: from cantor2.suse.de ([195.135.220.15]:54710 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ScipH-0001Mq-87
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 15:56:59 -0400
Message-ID: <4FD10785.8080900@suse.de>
Date: Thu, 07 Jun 2012 21:56:53 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339097465-22977-1-git-send-email-afaerber@suse.de>
	<1339097465-22977-8-git-send-email-afaerber@suse.de>
In-Reply-To: <1339097465-22977-8-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next 7/7] qom: Add
	QERR_PROPERTY_SET_AFTER_REALIZE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: pbonzini@redhat.com, Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Am 07.06.2012 21:31, schrieb Andreas F=C3=A4rber:
> From: Peter Maydell <peter.maydell@linaro.org>
>=20
> Add a new QError QERR_PROPERTY_SET_AFTER_REALIZE for attempts
> to set a QOM or qdev property after the object/device has been
> realized. This allows a slightly more informative diagnostic
> than the previous "Insufficient permission" message.
>=20
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
> ---
>  hw/qdev-properties.c    |   15 ++++++++++-----
>  qerror.c                |    4 ++++
>  qerror.h                |    3 +++
>  qom/object-properties.c |   24 ++++++++++++++++--------
>  qom/object.c            |    6 ++++--
>  5 files changed, 37 insertions(+), 15 deletions(-)
[...]
> diff --git a/qom/object.c b/qom/object.c
> index 40bc23a..c8a2cd7 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -817,7 +817,8 @@ void object_property_get(Object *obj, Visitor *v, c=
onst char *name,
>      }
> =20
>      if (!prop->get) {
> -        error_set(errp, QERR_PERMISSION_DENIED);
> +        error_set(errp, QERR_PROPERTY_SET_AFTER_REALIZE,
> +                  object_get_id(obj), name);
>      } else {
>          prop->get(obj, v, prop->opaque, name, errp);
>      }
> @@ -832,7 +833,8 @@ void object_property_set(Object *obj, Visitor *v, c=
onst char *name,
>      }
> =20
>      if (!prop->set) {
> -        error_set(errp, QERR_PERMISSION_DENIED);
> +        error_set(errp, QERR_PROPERTY_SET_AFTER_REALIZE,
> +                  object_get_id(obj), name);
>      } else {
>          prop->set(obj, v, prop->opaque, name, errp);
>      }

Hm, what does the lack of a setter have to do with realize? :)
Reverting these two hunks.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg