From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Scm2S-0001z9-6v
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 19:22:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Scm2Q-0002s2-9B
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 19:22:47 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:39866)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Scm2Q-0002rv-0T
	for qemu-devel@nongnu.org; Thu, 07 Jun 2012 19:22:46 -0400
Received: by dadv2 with SMTP id v2so1698415dad.4
	for <qemu-devel@nongnu.org>; Thu, 07 Jun 2012 16:22:44 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FD137BF.9050004@redhat.com>
Date: Fri, 08 Jun 2012 01:22:39 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1339097465-22977-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1339097465-22977-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH qom-next 0/7] QOM realize, revised
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws

Il 07/06/2012 21:30, Andreas Färber ha scritto:
> Hi Paolo,
> 
> I've modified the remainder of your static properties series, in particular:
> 
> "qdev: Push state up to Object":
> * OBJECT_STATE_CREATED -> OBJECT_STATE_INITIALIZED, to align with QOM API
> * Don't set early in object_instance_init() but in object_init_with_type()
>   after all initfns have been run.
> 
> "qom: add get_id":
> * _object_get_id() -> object_instance_get_id(), to avoid underscore
> * Avoid GCC ?: expression, suggested by malc.
> * Use newly introduced object_property_is_child() helper.
> 
> "qdev: Generalize properties to Objects":
> * Fixed indentation.
> 
> "qdev: Move bulk of qdev-properties.c to qom/object-properties.c":
> * Documentation fix: qdev_property_add_static -> object_property_add_static
> * Move from hw/qdev-properties.c to a new qom/object-properties.c
>   instead of qom/object.c.
> 
> "qom: Push static properties to Object":
> * Build fix: Adapt arm_gic_properties in hw/arm_gic.c as well.
> 
> "qom: Add "realized" property":
> * Adapted to OBJECT_STATE_INITIALIZED.
> 
> "qom: Add QERR_PROPERTY_SET_AFTER_REALIZE":
> * Redid the hw/qdev-properties.c changes in qom/object-properties.c.
> 
> If you're okay with these, I'll append them to the qom-next queue and will
> send out the PULL.

Of course, thank you very much!

Paolo