From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScuY4-0006AD-Im for qemu-devel@nongnu.org; Fri, 08 Jun 2012 04:28:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScuY2-0005sk-Pj for qemu-devel@nongnu.org; Fri, 08 Jun 2012 04:28:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10325) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScuY2-0005se-Hy for qemu-devel@nongnu.org; Fri, 08 Jun 2012 04:27:58 -0400 Message-ID: <4FD1B786.6090108@redhat.com> Date: Fri, 08 Jun 2012 10:27:50 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1338808409-19501-1-git-send-email-kwolf@redhat.com> <1338808409-19501-3-git-send-email-kwolf@redhat.com> <4FD0547F.6020001@msgid.tls.msk.ru> In-Reply-To: <4FD0547F.6020001@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/12] qcow2: fix the byte endian convertion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-devel@nongnu.org, anthony@codemonkey.ws Am 07.06.2012 09:13, schrieb Michael Tokarev: > On 04.06.2012 15:13, Kevin Wolf wrote: >> From: Zhi Yong Wu >> >> Signed-off-by: Zhi Yong Wu >> Reviewed-by: Stefan Hajnoczi >> Signed-off-by: Kevin Wolf > > It appears to be a good candidate for -stable, no? No, it's merely cosmetic. cpu_to_be64s() and be64_to_cpus() do the same, they both swap the byte order if the host is little endian. Kevin