From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScwCF-0004Rf-S4 for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:13:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScwCA-0001Rm-6b for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:13:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:6402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScwC9-0001RX-UH for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:13:30 -0400 Message-ID: <4FD1D044.4040704@redhat.com> Date: Fri, 08 Jun 2012 12:13:24 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <4FD0EA80.1000302@msgid.tls.msk.ru> In-Reply-To: <4FD0EA80.1000302@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL] iov* function rework (one more time) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Anthony Liguori , qemu-devel Am 07.06.2012 19:53, schrieb Michael Tokarev: > The following changes since commit 083dbf489d1b0592e910ecfb90b3858c23e49ab7: > > target-microblaze: fix swx build breakage (2012-06-07 10:12:00 +0200) > > are available in the git repository at: > > git://git.corpit.ru/qemu.git mjt-iov > > for you to fetch changes up to 85c5ece9bc0bd30f0573e43d1ddd756154ac6849: > > rewrite iov_send_recv() and move it to iov.c (2012-06-07 21:22:54 +0400) > > ---------------------------------------------------------------- > Michael Tokarev (11): > virtio-serial-bus: use correct lengths in control_out() message > change iov_* function prototypes to be more appropriate > rewrite iov_* functions > consolidate qemu_iovec_memset{,_skip}() into single function and use existing iov_memset() > allow qemu_iovec_from_buffer() to specify offset from which to start copying > consolidate qemu_iovec_copy() and qemu_iovec_concat() and make them consistent > change qemu_iovec_to_buf() to match other to,from_buf functions > rename qemu_sendv to iov_send, change proto and move declarations to iov.h > export iov_send_recv() and use it in iov_send() and iov_recv() > cleanup qemu_co_sendv(), qemu_co_recvv() and friends > rewrite iov_send_recv() and move it to iov.c I haven't reviewed the series in detail, and mostly ignored the cutils.c implementation and usage in other subsystems, but as far as the block layer is concerned: Acked-by: Kevin Wolf (Even though I don't agree that the new argument order of iov_from_buf() is better, but that's probably a matter of taste and the series has enough other good stuff) Kevin