From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38278) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScwKO-0007RZ-47 for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ScwKI-000396-MI for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:21:59 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36657 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScwKI-000392-Cc for qemu-devel@nongnu.org; Fri, 08 Jun 2012 06:21:54 -0400 Message-ID: <4FD1D23C.6040704@suse.de> Date: Fri, 08 Jun 2012 12:21:48 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1338292278-14141-1-git-send-email-hare@suse.de> <4FC4BF7F.2010004@redhat.com> <4FD13842.8000102@redhat.com> In-Reply-To: <4FD13842.8000102@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3][v17] megasas: LSI Megaraid SAS HBA emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Hannes Reinecke , qemu-devel@nongnu.org, Stefan Hajnoczi , Alexander Graf Am 08.06.2012 01:24, schrieb Paolo Bonzini: > Il 29/05/2012 14:22, Paolo Bonzini ha scritto: >> Il 29/05/2012 13:51, Hannes Reinecke ha scritto: >>> This is an updated patchset for megasas. Upon popular demand >>> I've split it into three parts, the header file, the emulation >>> itself, and a patch adding trace events to the emulation. >>> >>> Paolo, can you merge it via your tree? Or should I ask >>> someone else? >> >> Yes, of course. I'll wait for an Acked-by or a couple of weeks, >> whatever comes first. >=20 >> Acked-by: Alexander Graf >> Tested-by: Stefan Hajnoczi >=20 > Ok, pull request coming. :) Paolo, could you please squash the following fixups? Namely: * Drop semicolon after type_init() - unresolved comment from v14 * Make TypeInfo const * Revert unrelated whitespace change in pci_ids.h I told Hannes I'd send this to spare him another resend. It would also be good if someone could review my dependency patch, prompted by an earlier megasas submission: http://patchwork.ozlabs.org/patch/163647/ Maybe prepend it to this series' pci.mak change on scsi-next? diff --git a/hw/megasas.c b/hw/megasas.c index bf5f8cd..25e5c71 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -1935,7 +1935,7 @@ static void megasas_class_init(ObjectClass *oc, void *data) dc->desc =3D "LSI MegaRAID SAS 1078"; } -static TypeInfo megasas_info =3D { +static const TypeInfo megasas_info =3D { .name =3D "megasas", .parent =3D TYPE_PCI_DEVICE, .instance_size =3D sizeof(MegasasState), @@ -1947,4 +1947,4 @@ static void megasas_register_types(void) type_register_static(&megasas_info); } -type_init(megasas_register_types); +type_init(megasas_register_types) diff --git a/hw/pci_ids.h b/hw/pci_ids.h index 0306255..c2986aa 100644 --- a/hw/pci_ids.h +++ b/hw/pci_ids.h @@ -12,6 +12,7 @@ #define PCI_BASE_CLASS_STORAGE 0x01 #define PCI_BASE_CLASS_NETWORK 0x02 + #define PCI_CLASS_STORAGE_SCSI 0x0100 #define PCI_CLASS_STORAGE_IDE 0x0101 #define PCI_CLASS_STORAGE_RAID 0x0104 Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg