From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ScxqF-0004xO-Pe for qemu-devel@nongnu.org; Fri, 08 Jun 2012 07:59:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Scxq9-0005tZ-5x for qemu-devel@nongnu.org; Fri, 08 Jun 2012 07:58:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Scxq8-0005tU-UA for qemu-devel@nongnu.org; Fri, 08 Jun 2012 07:58:53 -0400 Message-ID: <4FD1E8F8.3090004@redhat.com> Date: Fri, 08 Jun 2012 05:58:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339097465-22977-1-git-send-email-afaerber@suse.de> <1339097465-22977-3-git-send-email-afaerber@suse.de> <4FD153CC.6040304@codemonkey.ws> <4FD1A5B8.20700@suse.de> <4FD1AD46.9040607@codemonkey.ws> In-Reply-To: <4FD1AD46.9040607@codemonkey.ws> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig66E4E5017D898140916BF54D" Subject: Re: [Qemu-devel] [PATCH qom-next 2/7] qom: Add get_id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: pbonzini@redhat.com, Luiz Capitulino , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig66E4E5017D898140916BF54D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/08/2012 01:44 AM, Anthony Liguori wrote: > Since qdev->id is NULL 90% of the time, I don't think a user can > realistically rely on it. I don't think changing the type of the data > in the error is going to be a problem. >=20 > Doesn't libvirt ignore the contents of an error object? Libvirt tries to parse the contents of an error object in order to reconstruct the most user-friendly message possible for libvirt's error message. There's already some special-casing in libvirt's code, and we can probably add more if you change the layout of particular errors. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig66E4E5017D898140916BF54D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP0ej4AAoJEKeha0olJ0NqVcwH/3mNun3bJgjXSWPNie3Alilt 4lxtDGhYH7eYiKbYVBySOEMKWGN6qe7bazI+hI6TV1nlYf307kHmYyGxTUV7/rGn 03IhxqR4TYjhg4t00FUxJrIzvvwmS3ftwTindqR0irWXJbeYMGqqd3+jMAVjTowj b/OrceAYE9beb2224NaflrTGRFMryuuuFc90YsWGwkhBhHePqeKrDTJCnYxwJlN2 8NoI9f1H1A0LODTJt8v989rWekbTEUqlDzEzVpMaMtGUA3ZUCeTtz5OjemRC9mu2 cUxlXbY0H0P2RKbBs5cP2PmdEi9afAVjH6yhFg/T2CvQiOw8jxkCGgcU6A0KEk8= =0Ows -----END PGP SIGNATURE----- --------------enig66E4E5017D898140916BF54D--