From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:43359)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdBSH-0006NY-7a
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 22:31:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdBSF-0005iI-Bo
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 22:31:08 -0400
Received: from cantor2.suse.de ([195.135.220.15]:59348 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdBSF-0005hs-2A
	for qemu-devel@nongnu.org; Fri, 08 Jun 2012 22:31:07 -0400
Message-ID: <4FD2B565.6040208@suse.de>
Date: Sat, 09 Jun 2012 04:31:01 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339206871-4706-1-git-send-email-afaerber@suse.de>
	<1339206871-4706-2-git-send-email-afaerber@suse.de>
	<CAEgOgz7zyOgXGfvB6E2AGY40y7AMKSBbrjzRvS9+q=rCEQ8GxQ@mail.gmail.com>
In-Reply-To: <CAEgOgz7zyOgXGfvB6E2AGY40y7AMKSBbrjzRvS9+q=rCEQ8GxQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/3] hw/xilinx_*: Share Xilinx devices
 between ppc and microblaze
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@petalogix.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, "Peter A. G. Crosthwaite" <peter.crothwaite@petalogix.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

Hi,

Am 09.06.2012 04:15, schrieb Peter Crosthwaite:
> On Sat, Jun 9, 2012 at 11:54 AM, Andreas F=E4rber <afaerber@suse.de> wr=
ote:
>> Speeds up the build.
>>
>> xilinx_ethlite uses tswap32() and is thus target-dependent.
>>
>> Signed-off-by: Andreas F=E4rber <afaerber@suse.de>
[...]
>> --- a/hw/Makefile.objs
>> +++ b/hw/Makefile.objs
>> @@ -59,6 +59,11 @@ hw-obj-$(CONFIG_PIIX4) +=3D piix4.o
>>  hw-obj-$(CONFIG_G364FB) +=3D g364fb.o
>>  hw-obj-$(CONFIG_JAZZ_LED) +=3D jazz_led.o
>>
>> +# Xilinx devices
>> +hw-obj-$(CONFIG_XILINX) +=3D xilinx_intc.o
>> +hw-obj-$(CONFIG_XILINX) +=3D xilinx_timer.o
>> +hw-obj-$(CONFIG_XILINX) +=3D xilinx_uartlite.o
>> +
>=20
> whats the plan with xilinx_axidma xilinx_axienet and  xilinx_ethlite?
> Should be fold them into this CONFIG_  or are these the exceptions to
> the rule as they are the annoying endian dependent ones?

The axi ones are in patch 3/3 as they are only used for microblaze, not
ppc, and they use qemu-log.h. Designed for pick-from-the-front*. :)

The ethlite has the endianness issue described in the cover letter. Once
solved, I'd expect it to be folded into CONFIG_XILINX as well, yes.

Obviously if you have better variable naming, feel free to suggest or to
change before Edgar applies, my stake is only that the variable names
match in both places and that we achieve some deduplification.

Cheers,
Andreas

* Depending on whether this or Blue's series goes in first, in which
case 2/3 gets obsoleted.

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg