From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39887)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdNVu-0006o1-B8
	for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:23:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdNVs-00047e-CR
	for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:23:41 -0400
Received: from cantor2.suse.de ([195.135.220.15]:59345 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdNVs-00047Y-5v
	for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:23:40 -0400
Message-ID: <4FD36A73.2010904@suse.de>
Date: Sat, 09 Jun 2012 17:23:31 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <cover.1339044751.git.peter.crosthwaite@petalogix.com>
	<74b943b975af2bfe203e13e3049960716ead0969.1339044751.git.peter.crosthwaite@petalogix.com>
In-Reply-To: <74b943b975af2bfe203e13e3049960716ead0969.1339044751.git.peter.crosthwaite@petalogix.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 1/4] hw: introduce standard SD host
	controller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Peter A. G. Crosthwaite" <peter.crosthwaite@petalogix.com>, i.mitsyanko@samsung.com, Kevin Wolf <kwolf@redhat.com>
Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, edgar.iglesias@gmail.com, m.kozlov@samsung.com, john.williams@petalogix.com

Am 07.06.2012 07:05, schrieb Peter A. G. Crosthwaite:
> From: Igor Mitsyanko <i.mitsyanko@samsung.com>
>=20
> Device model for standard SD Host Controller Interface (SDHCI) complian=
t with
> version 2.00 of SD association specification.
>=20
> Signed-off-by: Peter A. G. Crosthwaite <peter.crosthwaite@petalogix.com=
>
> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
[...]
> diff --git a/hw/sdhci.h b/hw/sdhci.h
> new file mode 100644
> index 0000000..afd0772
> --- /dev/null
> +++ b/hw/sdhci.h
> @@ -0,0 +1,310 @@
[...]
> +#ifndef _SDHC_H_
> +#define _SDHC_H_
[...]
> +#endif /* _SDHC_H_ */

Minor nit: Our malc insists on not using reserved identifiers starting
with underscore. s/_SDHC_H_/SDHCI_H/g ?

/-F

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg