From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54754) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdNe9-0002tj-Ao for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:32:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SdNe7-0008Nc-F5 for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:32:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SdNe7-0008NS-7a for qemu-devel@nongnu.org; Sat, 09 Jun 2012 11:32:11 -0400 Message-ID: <4FD36CBA.2070007@redhat.com> Date: Sat, 09 Jun 2012 17:33:14 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1339169713-31205-1-git-send-email-afaerber@suse.de> <1339169713-31205-2-git-send-email-afaerber@suse.de> <4FD365B7.4080307@redhat.com> <4FD368D2.2060109@suse.de> In-Reply-To: <4FD368D2.2060109@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/8] qapi: Add Visitor interfaces for uint*_t and int*_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: Paolo Bonzini , Michael Roth , Anthony Liguori , qemu-devel@nongnu.org On 06/09/12 17:16, Andreas F=C3=A4rber wrote: > Am 09.06.2012 17:03, schrieb Laszlo Ersek: >> On 06/08/12 17:35, Andreas F=C3=A4rber wrote: >>> From: Michael Roth >>> >>> This adds visitor interfaces for fixed-width integers types. >>> Implementing these in visitors is optional, otherwise we fall back to >>> visit_type_int() (int64_t) with some additional bounds checking to av= oid >>> integer overflows for cases where the value fetched exceeds the bound= s >>> of our target C type. >> >>> diff --git a/qapi/qapi-visit-core.h b/qapi/qapi-visit-core.h >>> index e850746..a19d70c 100644 >>> --- a/qapi/qapi-visit-core.h >>> +++ b/qapi/qapi-visit-core.h >>> @@ -52,6 +52,14 @@ struct Visitor >>> void (*start_handle)(Visitor *v, void **obj, const char *kind, >>> const char *name, Error **errp); >>> void (*end_handle)(Visitor *v, Error **errp); >>> + void (*type_uint8)(Visitor *v, uint8_t *obj, const char *name, E= rror **errp); >>> + void (*type_uint16)(Visitor *v, uint16_t *obj, const char *name,= Error **errp); >>> + void (*type_uint32)(Visitor *v, uint32_t *obj, const char *name,= Error **errp); >>> + void (*type_uint64)(Visitor *v, uint64_t *obj, const char *name,= Error **errp); >>> + void (*type_int8)(Visitor *v, int8_t *obj, const char *name, Err= or **errp); >>> + void (*type_int16)(Visitor *v, int16_t *obj, const char *name, E= rror **errp); >>> + void (*type_int32)(Visitor *v, int32_t *obj, const char *name, E= rror **errp); >>> + void (*type_int64)(Visitor *v, int64_t *obj, const char *name, E= rror **errp); >>> }; >>> =20 >>> void visit_start_handle(Visitor *v, void **obj, const char *kind, >>> @@ -69,6 +77,14 @@ void visit_end_optional(Visitor *v, Error **errp); >>> void visit_type_enum(Visitor *v, int *obj, const char *strings[], >>> const char *kind, const char *name, Error **err= p); >>> void visit_type_int(Visitor *v, int64_t *obj, const char *name, Erro= r **errp); >>> +void visit_type_uint8(Visitor *v, uint8_t *obj, const char *name, Er= ror **errp); >>> +void visit_type_uint16(Visitor *v, uint16_t *obj, const char *name, = Error **errp); >>> +void visit_type_uint32(Visitor *v, uint32_t *obj, const char *name, = Error **errp); >>> +void visit_type_uint64(Visitor *v, uint64_t *obj, const char *name, = Error **errp); >>> +void visit_type_int8(Visitor *v, int8_t *obj, const char *name, Erro= r **errp); >>> +void visit_type_int16(Visitor *v, int16_t *obj, const char *name, Er= ror **errp); >>> +void visit_type_int32(Visitor *v, int32_t *obj, const char *name, Er= ror **errp); >>> +void visit_type_int64(Visitor *v, int64_t *obj, const char *name, Er= ror **errp); >>> void visit_type_bool(Visitor *v, bool *obj, const char *name, Error = **errp); >>> void visit_type_str(Visitor *v, char **obj, const char *name, Error = **errp); >>> void visit_type_number(Visitor *v, double *obj, const char *name, Er= ror **errp); >> >> Shouldn't "scripts/qapi.py" be extended accordingly? (The c_type funct= ion.) >=20 > What does that affect? > Is it a blocker for this PULL or an improvement for a follow-up? The latter. As long as nothing actually uses these types there's no probl= em. Laszlo