From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdkgl-0005Wj-CS for qemu-devel@nongnu.org; Sun, 10 Jun 2012 12:08:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sdkgj-000063-II for qemu-devel@nongnu.org; Sun, 10 Jun 2012 12:08:26 -0400 Received: from cantor2.suse.de ([195.135.220.15]:54337 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdkgj-00005p-CR for qemu-devel@nongnu.org; Sun, 10 Jun 2012 12:08:25 -0400 Message-ID: <4FD4C673.607@suse.de> Date: Sun, 10 Jun 2012 18:08:19 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <017b2d0961daf25d156270f69962fa82ba5be00c.1339333471.git.blauwirbel@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] tests: add gcov target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org Am 10.06.2012 15:04, schrieb Blue Swirl: > Add support for compiling for GCOV test coverage, enabled > with '--enable-gcov' during configure. >=20 > After tests, test coverage can be reported with 'make gcov'. >=20 > Signed-off-by: Blue Swirl > --- > configure | 19 ++++++++++++++++++- > tests/Makefile | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 58 insertions(+), 1 deletions(-) >=20 > diff --git a/configure b/configure > index b4fb715..d773f4e 100755 > --- a/configure > +++ b/configure [...] > @@ -2851,10 +2859,14 @@ fi > # End of CC checks > # After here, no more $cc or $ld runs > =20 > -if test "$debug" =3D "no" ; then > +if test "$gcov" =3D "yes" ; then > + CFLAGS=3D"-fprofile-arcs -ftest-coverage -g $CFLAGS" > + LDFLAGS=3D"-fprofile-arcs -ftest-coverage $LDFLAGS" > +elif test "$debug" =3D "no" ; then > CFLAGS=3D"-O2 $CFLAGS" > fi Is it intentional that no -O option is being specified for gcov? > =20 > + > # Consult white-list to determine whether to enable werror > # by default. Only enable by default for git builds > z_version=3D`cut -f3 -d. $source_path/VERSION` [snip] Am I understanding correctly that this gcov setup must be done in a separate build dir from an actually "usable" build? Small improvement: Please either include a cover letter for a threaded series or send unrelated patches separately. Groups replies more nicely. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg