From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdljx-0005IJ-3e for qemu-devel@nongnu.org; Sun, 10 Jun 2012 13:15:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sdlju-0005pN-TR for qemu-devel@nongnu.org; Sun, 10 Jun 2012 13:15:48 -0400 Received: from mout.web.de ([212.227.17.12]:50977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sdlju-0005j2-DU for qemu-devel@nongnu.org; Sun, 10 Jun 2012 13:15:46 -0400 Message-ID: <4FD4D63E.5020602@web.de> Date: Sun, 10 Jun 2012 19:15:42 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <20120610165957.3942.89495.stgit@bling.home> In-Reply-To: <20120610165957.3942.89495.stgit@bling.home> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig644DA6A5AA7AB57EEEBCEF56" Subject: Re: [Qemu-devel] [RFC PATCH] msix: Support specifying offsets, BARs, and capability location List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: qemu-devel@nongnu.org, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig644DA6A5AA7AB57EEEBCEF56 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2012-06-10 19:02, Alex Williamson wrote: > msix_init has very little configurability as to how it lays out > MSI/X for a device. It claims to resize BARs, but doesn't > actually do this anymore. This patch allows MSI/X to be fully > specified, which is necessary both for emulated devices trying > to match the physical layout of a hardware device as well as for > any kind of device assignment. >=20 > The original intent of msix_init seems to have been to allow > completely virtual devices so enable MSI/X without knowing > anything about it. A sort of "here's a BAR and a device, add > MSI/X to it". We've already dropped the resize support with > the memory API, and I think it makes sense to tune the interface > to something that still makes it easy for virtual devices to use, > but allows the full specification for realistically creating > emulated devices using MSI/X. >=20 > Signed-off-by: Alex Williamson > --- >=20 > This needs more testing, but I wanted to send it out in case someone > else is working on something similar. In order to not modify the > generic capability adding code VFIO needs to tell qemu about ever > capability for a device. The main roadblock to doing that is that > msix_init does not provide sufficient specification of the MSI/X area > to match a physical device. This solves that. Reminds me that you asked for my version: http://git.kiszka.org/?p=3Dqemu.git;a=3Dshortlog;h=3Drefs/heads/queues/ms= i specifically the top two commits. WIP, just picked the old commits, result untested. Still need to look into your version. Jan --------------enig644DA6A5AA7AB57EEEBCEF56 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk/U1j4ACgkQitSsb3rl5xSj2wCgo8wyB6BuJmcGN5BG2BWNZnVp 61wAnRK1kyUye3zxR/L1KxxaE5GQQGgk =veXt -----END PGP SIGNATURE----- --------------enig644DA6A5AA7AB57EEEBCEF56--