From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36919)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sdm66-0003hq-B7
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 13:38:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sdm64-0002xE-Kv
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 13:38:41 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56980 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sdm64-0002wz-EM
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 13:38:40 -0400
Message-ID: <4FD4DB9B.8070208@suse.de>
Date: Sun, 10 Jun 2012 19:38:35 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1339097465-22977-1-git-send-email-afaerber@suse.de>
	<1339097465-22977-2-git-send-email-afaerber@suse.de>
	<4FD1530D.4010706@codemonkey.ws> <4FD4C1F3.2010203@redhat.com>
In-Reply-To: <4FD4C1F3.2010203@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-next 1/7] qdev: Push state up to Object
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Markus Armbruster <armbru@redhat.com>

Am 10.06.2012 17:49, schrieb Paolo Bonzini:
> Il 08/06/2012 03:19, Anthony Liguori ha scritto:
>>>
>>> +typedef enum ObjectState {
>>> +    OBJECT_STATE_INITIALIZED =3D 1,
>>> +    OBJECT_STATE_REALIZED,
>>> +} ObjectState;
>>
>> I think using a bool would be better since it reduces the temptation t=
o
>> add additional states.
>=20
> In fact someone already discussed having a third state for block
> devices... :)

I would expect that file_opened state to remain internal to the block
layer. Thought we discussed that on IRC?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg