From: "Andreas Färber" <afaerber@suse.de>
To: peter.chubb@nicta.com.au
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org, Philip OSullivan <philipo@ok-labs.com>
Subject: Re: [Qemu-devel] [patch V9 0/5] i.MX31: Add initial support
Date: Mon, 11 Jun 2012 02:14:08 +0200 [thread overview]
Message-ID: <4FD53850.7090808@suse.de> (raw)
In-Reply-To: <20120607033114.398183928@nicta.com.au>
Am 07.06.2012 05:31, schrieb peter.chubb@nicta.com.au:
> Changes since V8: Recovered my stuff-up from backup --- changes that
> were in V7 are back in!
> Andreas's comments addressed
> (except adding MAINTAINER field)
Why? Are you unwilling to maintain the code you contribute, or do you
have questions on placement, format or something we can help resolve?
The Makefile system has changed by now. The way you're adding the files
you could move them to hw/arm/Makefile.objs. I'd suggest to add a
CONFIG_IMX=y in default-configs/arm-softmmu.mak and to add the
CPU-independent files (serial, ccm, timer, even avic apparently) to
hw/Makefile.objs instead using hw-obj-$(CONFIG_IMX).
For an example see my Tegra2 branch:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/tegra
Andreas
> Peter Maydell's comments against V6/7 are addressed.
>
> Peter C
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-06-11 0:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 3:31 [Qemu-devel] [patch V9 0/5] i.MX31: Add initial support peter.chubb
2012-06-07 3:31 ` [Qemu-devel] [patch V9 1/5] i.MX: UART support peter.chubb
2012-06-07 3:31 ` [Qemu-devel] [patch V9 2/5] i.MX31: Clock Control Module peter.chubb
2012-06-07 3:31 ` [Qemu-devel] [patch V9 3/5] i.MX31: Timers peter.chubb
2012-06-07 3:31 ` [Qemu-devel] [patch V9 4/5] i.MX31: Interrupt Controller peter.chubb
2012-06-07 3:31 ` [Qemu-devel] [patch V9 5/5] i.MX31: KZM-ARM11-01 evaluation board peter.chubb
2012-06-11 0:14 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD53850.7090808@suse.de \
--to=afaerber@suse.de \
--cc=peter.chubb@nicta.com.au \
--cc=peter.maydell@linaro.org \
--cc=philipo@ok-labs.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).