From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58944)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdsGu-0006dL-S1
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 20:14:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdsGt-0000Hf-20
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 20:14:16 -0400
Received: from cantor2.suse.de ([195.135.220.15]:46223 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SdsGs-0000Hb-Qv
	for qemu-devel@nongnu.org; Sun, 10 Jun 2012 20:14:14 -0400
Message-ID: <4FD53850.7090808@suse.de>
Date: Mon, 11 Jun 2012 02:14:08 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <20120607033114.398183928@nicta.com.au>
In-Reply-To: <20120607033114.398183928@nicta.com.au>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [patch V9 0/5] i.MX31: Add initial support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: peter.chubb@nicta.com.au
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Philip OSullivan <philipo@ok-labs.com>

Am 07.06.2012 05:31, schrieb peter.chubb@nicta.com.au:
> Changes since V8: Recovered my stuff-up from backup --- changes that
> 	were in V7 are back in!
> 	Andreas's comments addressed

> (except adding MAINTAINER field)

Why? Are you unwilling to maintain the code you contribute, or do you
have questions on placement, format or something we can help resolve?

The Makefile system has changed by now. The way you're adding the files
you could move them to hw/arm/Makefile.objs. I'd suggest to add a
CONFIG_IMX=3Dy in default-configs/arm-softmmu.mak and to add the
CPU-independent files (serial, ccm, timer, even avic apparently) to
hw/Makefile.objs instead using hw-obj-$(CONFIG_IMX).
For an example see my Tegra2 branch:
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/tegra

Andreas

> 	Peter Maydell's comments against V6/7 are addressed.
>=20
> Peter C

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg