From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sdyox-0004lt-9x
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 03:13:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sdyov-0005zS-Lt
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 03:13:50 -0400
Received: from cantor2.suse.de ([195.135.220.15]:34608 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1Sdyov-0005zL-Fj
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 03:13:49 -0400
Message-ID: <4FD59AA2.3000707@suse.de>
Date: Mon, 11 Jun 2012 09:13:38 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1338858018-17189-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<CAFEAcA-VUzcWSjH46SHTfx5bBAshyiCZ3GfnENpOwbYq+Opcog@mail.gmail.com>
In-Reply-To: <CAFEAcA-VUzcWSjH46SHTfx5bBAshyiCZ3GfnENpOwbYq+Opcog@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, quintela@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, owasserm@redhat.com, pbonzini@redhat.com, akong@redhat.com, yamahata@valinux.co.jp

Am 05.06.2012 12:00, schrieb Peter Maydell:
> On 5 June 2012 02:00, Michael Roth <mdroth@linux.vnet.ibm.com> wrote:
>> +The first step is to move your device struct definition to a header f=
ile.  This
>> +header file should only contain the struct definition and any preproc=
essor
>> +declarations you need to define the structure.  This header file will=
 act as
>> +the source for the QC IDL compiler.
>=20
> I don't think this is a fantastic idea -- the device struct should be
> private to the device, and having it in a standalone header file is
> asking for users of the device to illicitly include it and access
> internals that they shouldn't.

But that is exactly where realize is headed. PCIBus, a9mp_priv etc.
structs will need to be made public so that they can be embedded.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg