From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sdyvf-0006ZR-Ma
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 03:20:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SdyvY-0007EL-OU
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 03:20:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:9468)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1SdyvY-0007EE-GX
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 03:20:40 -0400
Message-ID: <4FD59C3F.2020306@redhat.com>
Date: Mon, 11 Jun 2012 09:20:31 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1338858018-17189-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1338858018-17189-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<CAFEAcA-VUzcWSjH46SHTfx5bBAshyiCZ3GfnENpOwbYq+Opcog@mail.gmail.com>
	<4FD59AA2.3000707@suse.de>
In-Reply-To: <4FD59AA2.3000707@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 01/17] qidl: add QEMU IDL processor
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, aliguori@us.ibm.com, quintela@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, owasserm@redhat.com, akong@redhat.com, yamahata@valinux.co.jp

Il 11/06/2012 09:13, Andreas F=C3=A4rber ha scritto:
>>> >> +The first step is to move your device struct definition to a head=
er file.  This
>>> >> +header file should only contain the struct definition and any pre=
processor
>>> >> +declarations you need to define the structure.  This header file =
will act as
>>> >> +the source for the QC IDL compiler.
>> >=20
>> > I don't think this is a fantastic idea -- the device struct should b=
e
>> > private to the device, and having it in a standalone header file is
>> > asking for users of the device to illicitly include it and access
>> > internals that they shouldn't.
> But that is exactly where realize is headed. PCIBus, a9mp_priv etc.
> structs will need to be made public so that they can be embedded.

I thought that was just a convenience choice, not a necessity.  The
children objects could just as well be heap-allocated.

Paolo