From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Se2e5-0004rA-1u
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 07:18:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1Se2dy-00042w-PA
	for qemu-devel@nongnu.org; Mon, 11 Jun 2012 07:18:52 -0400
Message-ID: <4FD5D410.9030707@redhat.com>
Date: Mon, 11 Jun 2012 14:18:40 +0300
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4FCF691A.10502@siemens.com> <4FD5C352.4000004@redhat.com>
	<4FD5C89D.2010408@siemens.com>
In-Reply-To: <4FD5C89D.2010408@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] KVM: i8254: Clean up limit constant
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, kvm <kvm@vger.kernel.org>, qemu-stable <qemu-stable@nongnu.org>

On 06/11/2012 01:29 PM, Jan Kiszka wrote:
> On 2012-06-11 12:07, Avi Kivity wrote:
>> On 06/06/2012 05:28 PM, Jan Kiszka wrote:
>>> Due to a offset between the clock used to generate the in-kernel
>>> count_load_time (CLOCK_MONOTONIC) and the clock used for processing this
>>> in userspace (vm_clock), reading back the output of PIT channel 2 via
>>> port 0x61 was broken. One use cases that suffered from it was the CPU
>>> frequency calibration of SeaBIOS, which also affected IDE/AHCI timeouts.
>>>
>>> This fixes it by calibrating the offset between both clocks on
>>> kvm_pit_get and adjusting the kernel value before saving it in the
>>> userspace state. As the calibration only works while the vm_clock is
>>> running, we cache the in-kernel state across stopped phases.
>> 
>> Applied, thanks.
>> 
>>> +    clock_offset = LLONG_MAX;
>> 
>> INT64_MAX would me more strictly correct, but in practice it makes no
>> difference.
> 
> Was looking for this, just not long enough. Need to print some cheat
> sheet. However, let's clean this up immediately:
> 
> ---8<---
> 
> clock_offset is int64_t.
> 

Thanks, folded.


-- 
error compiling committee.c: too many arguments to function