From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] atapi: implement READ DISC INFORMATION
Date: Mon, 11 Jun 2012 14:50:48 +0200 [thread overview]
Message-ID: <4FD5E9A8.1000801@redhat.com> (raw)
In-Reply-To: <4FD5E842.5040108@redhat.com>
Il 11/06/2012 14:44, Kevin Wolf ha scritto:
>> > @@ -1048,6 +1078,7 @@ static const struct {
>> > [ 0x5a ] = { cmd_mode_sense, /* (10) */ 0 },
>> > [ 0xa8 ] = { cmd_read, /* (12) */ CHECK_READY },
>> > [ 0xad ] = { cmd_read_dvd_structure, CHECK_READY },
>> > + [ 0x51 ] = { cmd_read_disc_information, CHECK_READY },
>> > [ 0xbb ] = { cmd_set_speed, 0 },
>> > [ 0xbd ] = { cmd_mechanism_status, 0 },
>> > [ 0xbe ] = { cmd_read_cd, CHECK_READY },
> Please keep the table sorted.
>
> Also, if I was the SCSI maintainer, I would require qtest cases for all
> four patches. ;-)
Me too. However, I'm waiting for Stefan to resubmit his virtio bindings
for qtest.
Paolo
next prev parent reply other threads:[~2012-06-11 12:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 5:24 [Qemu-devel] [PATCH 0/4] Small SCSI command improvements Paolo Bonzini
2012-06-11 5:24 ` [Qemu-devel] [PATCH 1/4] scsi: simplify and fix handling of the VPD page length field Paolo Bonzini
2012-06-11 5:24 ` [Qemu-devel] [PATCH 2/4] scsi: add a qdev property for the disk's WWN Paolo Bonzini
2012-06-11 5:24 ` [Qemu-devel] [PATCH 3/4] atapi: implement READ DISC INFORMATION Paolo Bonzini
2012-06-11 12:44 ` Kevin Wolf
2012-06-11 12:50 ` Paolo Bonzini [this message]
2012-06-11 5:24 ` [Qemu-devel] [PATCH 4/4] scsi-disk: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD5E9A8.1000801@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).