From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SeNXn-0002YX-Fj
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 05:37:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SeNXh-00009H-TY
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 05:37:47 -0400
Received: from cantor2.suse.de ([195.135.220.15]:38624 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SeNXh-00008s-MO
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 05:37:41 -0400
Message-ID: <4FD70F0A.8050609@suse.de>
Date: Tue, 12 Jun 2012 11:42:34 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1338984323-21914-1-git-send-email-jfrei@de.ibm.com>
	<1338984323-21914-5-git-send-email-jfrei@de.ibm.com>
In-Reply-To: <1338984323-21914-5-git-send-email-jfrei@de.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/8] s390: stop target cpu on sigp initial
	reset
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jens Freimann <jfrei@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Heinz Graalfs <graalfs@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

Jens Freimann wrote:
> From: Christian Borntraeger <borntraeger@de.ibm.com>
>
> We must not run the target cpu after an initial reset. This makes
> system_reset more reliable for smp guests.
>   

Why?

Alex

> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  target-s390x/kvm.c |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
> index 93a8431..73cfd1f 100644
> --- a/target-s390x/kvm.c
> +++ b/target-s390x/kvm.c
> @@ -318,6 +318,7 @@ static int s390_cpu_initial_reset(CPUS390XState *env)
>  {
>      int i;
>  
> +    s390_del_running_cpu(env);
>      if (kvm_vcpu_ioctl(env, KVM_S390_INITIAL_RESET, NULL) < 0) {
>          perror("cannot init reset vcpu");
>      }
>