From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SeO0I-0007n3-BS
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 06:07:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SeO0C-00057X-6Q
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 06:07:13 -0400
Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:43568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SeO0B-000574-Tp
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 06:07:08 -0400
Received: from /spool/local
	by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 12 Jun 2012 11:07:05 +0100
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q5CA72CH2052232
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 11:07:02 +0100
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q5C9stwO025907
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 05:54:55 -0400
Message-ID: <4FD714C6.5040400@de.ibm.com>
Date: Tue, 12 Jun 2012 12:07:02 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1338984323-21914-1-git-send-email-jfrei@de.ibm.com>
	<1338984323-21914-6-git-send-email-jfrei@de.ibm.com>
	<4FD712D4.3040401@suse.de>
In-Reply-To: <4FD712D4.3040401@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Jens Freimann <jfrei@de.ibm.com>, Heinz Graalfs <graalfs@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, =?ISO-8859-1?Q?Andreas_F=E4?= =?ISO-8859-1?Q?rber?= <afaerber@suse.de>

On 12/06/12 11:58, Alexander Graf wrote:
> Jens Freimann wrote:
>> From: Christian Borntraeger <borntraeger@de.ibm.com>
>>
>> The sclp facility on s390 is a hardware that is external to the cpu.
>> Lets cleanup the definitions and move the functionality into a separate
>> file under hw/.
>>   
> 
> Phew. I'm not sure this is a great idea. At least not the way the code
> is structured now. Andreas, do you have any idea how to get this done
> nicely? We'd have to invent our own bus to communicate to the device,
> right? And then also actually spawn one.

There are followup patches which add qom etc see patch 6. Can you look at
the end result?