From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SePo6-0000dg-PS
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:02:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SePnx-0007RF-JE
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:02:46 -0400
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:40072)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1SePnx-0007Qe-AP
	for qemu-devel@nongnu.org; Tue, 12 Jun 2012 08:02:37 -0400
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 12 Jun 2012 13:02:34 +0100
Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com
	[9.149.37.249])
	by d06nrmr1707.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q5CC2T0W2412708
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 13:02:29 +0100
Received: from d06av08.portsmouth.uk.ibm.com (loopback [127.0.0.1])
	by d06av08.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q5CC2Rb7015578
	for <qemu-devel@nongnu.org>; Tue, 12 Jun 2012 06:02:27 -0600
Message-ID: <4FD72FD4.6020008@de.ibm.com>
Date: Tue, 12 Jun 2012 14:02:28 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1338984323-21914-1-git-send-email-jfrei@de.ibm.com>
	<1338984323-21914-3-git-send-email-jfrei@de.ibm.com>
	<4FD70CC0.7000901@suse.de> <4FD725EB.7050501@de.ibm.com>
	<4FD72EC2.2010105@suse.de>
In-Reply-To: <4FD72EC2.2010105@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/8] s390: autodetect map private
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Jens Freimann <jfrei@de.ibm.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Heinz Graalfs <graalfs@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>

On 12/06/12 13:57, Alexander Graf wrote:
> Since it lives in an s390 specific branch, the function name should probably be called s390 specific. If we ever need another architecture to have a kvm specific ram allocator, we can make it generic when that time comes. Until then, let's treat s390 as the oddball it is :).
> 
> Apart from that, this approach looks a lot nicer, yes.

But then I have to have a *s390* function declared in kvm.h and your other comment
hits me. You got me in a trap here, heh? ;-)