From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Hrdina <phrdina@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 4/4] fdc: fix interrupt handling
Date: Tue, 12 Jun 2012 14:59:33 +0200 [thread overview]
Message-ID: <4FD73D35.7000000@redhat.com> (raw)
In-Reply-To: <83fb3a579f13cec8bd6a62a486911627f36e7185.1339499796.git.phrdina@redhat.com>
Il 12/06/2012 13:19, Pavel Hrdina ha scritto:
> } else {
> - /* XXX: status0 handling is broken for read/write
> - commands, so we do this hack. It should be suppressed
> - ASAP */
> - fdctrl->fifo[0] =
> - FD_SR0_SEEK | (cur_drv->head << 2) | GET_CUR_DRV(fdctrl);
> + fdctrl->fifo[0] = (fdctrl->status0 & ~FD_SR0_HEAD) | GET_CUR_DRV(fdctrl);
Should bit 0 be cleared also, before ORing GET_CUR_DRV(fdctrl)?
Paolo
next prev parent reply other threads:[~2012-06-12 12:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 11:19 [Qemu-devel] [PATCH v3 0/4] fdc: fix/rewrite seek, media_changed and interrupt handling Pavel Hrdina
2012-06-12 11:19 ` [Qemu-devel] [PATCH v3 1/4] fdc: fix implied seek while there is no medina in drive Pavel Hrdina
2012-06-12 11:19 ` [Qemu-devel] [PATCH v3 2/4] fdc-test: introduced qtest read_without_media Pavel Hrdina
2012-06-12 11:19 ` [Qemu-devel] [PATCH v3 3/4] fdc: rewrite seek and DSKCHG bit handling Pavel Hrdina
2012-06-12 13:03 ` Paolo Bonzini
2012-06-12 11:19 ` [Qemu-devel] [PATCH v3 4/4] fdc: fix interrupt handling Pavel Hrdina
2012-06-12 12:59 ` Paolo Bonzini [this message]
2012-06-13 11:43 ` Pavel Hrdina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD73D35.7000000@redhat.com \
--to=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).